I would say that's a bug. This option should only be set if the input
itself sets the hostname. If it is inside the message and there is no
reason to pre-parse it, the option should not be set.

eSX: up for a PR? Would be great!

Raienr

2018-08-01 14:35 GMT+02:00 Andre Lorbach <[email protected]>:
> Imkafka.c was based on existing input plugins and that code in the comment
> block is properly left from original code imkafka was based on.
> I don't see a problem uncommenting that one line to enable support setting
> the hostname property.
>
> Best regards,
> Andre Lorbach
>
>> -----Original Message-----
>> From: rsyslog [mailto:[email protected]] On Behalf Of
> eSX
>> via rsyslog
>> Sent: Wednesday, August 1, 2018 1:33 PM
>> To: [email protected]
>> Cc: eSX <[email protected]>
>> Subject: [rsyslog] Why imkafka disable PARSE_HOSTNAME?
>>
>> Recently, I'm using imkafka to receive message which logged by another
>> servers.
>> But I can't get the $hostname from my syslog formated logs via rsyslog.
>> My log is a standard syslog with "legacy syslog" format.
>>
>> After reading the code, I found:
>> pmrfc3164.c parse host only (pMsg->msgFlags & PARSE_HOSTNAME) I found
>> many input method via network had set  PARSE_HOSTNAME in message
>> dispatching, but imkafa commeted it in imkafka.c:179 (rsyslog v8.36.0).
>> So the hostname which message from imkafka can not be parsed.
>>
>> The code had been there from the initial release.
>>
>> I uncomment it, compile & run, seems every thing is fine.
>>
>> So my questions is: Is there any known bugs or problem in this case?
>> Or, what is the reason to forbid imkafka parse the hostname?
>>
>> Thanks
>>
>> --
>> eSX
>> _______________________________________________
>> rsyslog mailing list
>> http://lists.adiscon.net/mailman/listinfo/rsyslog
>> http://www.rsyslog.com/professional-services/
>> What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL:
>> This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites
> beyond
>> our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
> http://www.rsyslog.com/professional-services/
> What's up with rsyslog? Follow https://twitter.com/rgerhards
> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of 
> sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T 
> LIKE THAT.
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of 
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE 
THAT.

Reply via email to