The Labelled Priority Patch from http://www.parliant.com/~cmh/rt/ for RT 3.6 doesn't seem to work for me. The text labels appear in the basic panel but any values set are ignored (tickets are created with initial & final values of 0) can anyone confirm they have the patch working on RT 3.6.

RT 3.6.1 does the same thing.

I have re-attached the patch cause I had to change the headings in the original as the diff wasn't recognised by patch.

--- share/html/Elements/RT__Ticket/ColumnMap
+++ share/html/Elements/RT__Ticket/ColumnMap
@@ -158,17 +158,17 @@
    },
    Priority => {
        attribute => 'Priority',
-        value     => sub { return $_[0]->Priority }
+ value => sub { return $RT::PriorityType?$_[0]->PriorityAsString() : $_[0]->Priority }
    },
    InitialPriority => {
        attribute => 'InitialPriority',
        name => 'Initial Priority',
-        value     => sub { return $_[0]->InitialPriority }
+ value => sub { return $RT::PriorityType?$_[0]->InitialPriorityAsString(): $_[0]->InitialPriority }
    },
    FinalPriority => {
        attribute => 'FinalPriority',
        name => 'Final Priority',
-        value     => sub { return $_[0]->FinalPriority }
+ value => sub { return $RT::PriorityType?$_[0]->FinalPriorityAsString():$_[0]->FinalPriority }
    },
    EffectiveId => {
        attribute => 'EffectiveId',
--- share/html/Elements/SelectPriority
+++ share/html/Elements/SelectPriority
@@ -0,0 +1,34 @@
+%#
+
+<SELECT NAME ="<%$Name%>">
+% foreach $priidx (@RT::PrioritySortedKeys) {
+%   my($value)=$RT::PriorityLabels{$priidx};
+%   my($prilabel)=$priidx;
+%   if ( $priidx eq $defprilabel ) {
+%     $prilabel .= " (".$defprivalue.")" if ($RT::PriorityType > 1);
+<OPTION VALUE="<%$defprivalue%>" SELECTED><%$prilabel%></OPTION>
+%   } else {
+%     $prilabel .= " (".$value.")" if ($RT::PriorityType > 1);
+<OPTION VALUE="<%$value%>"><%$prilabel%></OPTION>
+%   }
+% }
+</SELECT>
+<%ARGS>
+$Name => undef
+$Default => undef
+
+</%ARGS>
+<%INIT>
+my($priidx,$defprilabel,$defprivalue);
+foreach $priidx (@RT::PrioritySortedKeys) {
+      if ( $Default >= $RT::PriorityLabels{$priidx}) {
+              # save current equivalent priority label
+              $defprilabel=$priidx;
+              # save current priority value to prevent tickets from having
+              #  their priorities "snap"ed to closest level
+              $defprivalue=$Default;
+              last;
+      }
+}
+</%INIT>
+
--- share/html/Search/Bulk.html
+++ share/html/Search/Bulk.html
@@ -100,7 +100,11 @@
<tr><td class="label"> <&|/l&>Make subject</&>: </td>
<td class="value"> <input name="Subject" size="20" /> </td></tr>
<tr><td class="label"> <&|/l&>Make priority</&>: </td>
-<td class="value"> <input name="Priority" size="4" /> </td></tr>
+% if ($RT::PriorityType) {
+ <td class=value><& /Elements/SelectPriority, Name => 'Priority', Default => 0 &></td></tr>
+% } else {
+       <td class=value> <INPUT Name="Priority" SIZE=4> </td></tr>
+% }
<tr><td class="label"> <&|/l&>Make queue</&>: </td>
<td class="value"> <& /Elements/SelectQueue, Name => "Queue" &> </td></tr>
<tr><td class="label"> <&|/l&>Make Status</&>: </td>
--- share/html/Search/Elements/PickBasics
+++ share/html/Search/Elements/PickBasics
@@ -151,7 +151,11 @@
</td><td>
<& /Elements/SelectEqualityOperator, Name => "PriorityOp" &>
</td><td>
-<input name="ValueOfPriority" size="5" />
+%  if ($RT::PriorityType) {
+   <&/Elements/SelectPriority, Name=>"ValueOfPriority" &>
+%  } else {
+   <INPUT Name="ValueOfPriority" SIZE=5>
+%  }
</td>
</tr>
<tr>
--- share/html/Ticket/Create.html
+++ share/html/Ticket/Create.html
@@ -177,8 +177,16 @@
                title_class=> 'inverse',
                color => "#993333" &>
<table border="0">
+% if ($RT::PriorityType) {
+<tr><td align=right><&|/l&>Priority</&>:</td><td><&/Elements/SelectPriority, name=>"InitialPriority", default=> $ARGS{InitialPriority}?$ARGS{InitialPriority} :$QueueObj->InitialPriority &></td></tr>
+%} else {
<tr><td align="right"><&|/l&>Priority</&>:</td><td><input size="3" name="InitialPriority" value="<% $ARGS{InitialPriority} ? $ARGS{InitialPriority} : $QueueObj->InitialPriority %>" /></td></tr>
+%}
+% if ($RT::PriorityType) {
+<tr><td align=right><&|/l&>Final Priority</&>:</td><td><&/Elements/SelectPriority, name=>"FinalPriority", default=> $ARGS{FinalPriority}?$ARGS{FinalPriority} :$QueueObj->FinalPriority &></td></tr>
+%} else {
<tr><td align="right"><&|/l&>Final Priority</&>:</td><td><input size="3" name="FinalPriority" value="<% $ARGS{FinalPriority} ? $ARGS{FinalPriority} : $QueueObj->FinalPriority %>" /></td></tr>
+%}
<tr><td align="right"><&|/l&>Time Estimated</&>:</td>
<td>
<input size="3" name="TimeEstimated" value="<%$ARGS{TimeEstimated}%>" />
@@ -200,7 +208,7 @@
</&>
<br />
<&|/Widgets/TitleBox, title => loc("Dates"),
-               title_class=> 'inverse',
+               Title_class=> 'inverse',
                 color => "#663366" &>

<table>
--- share/html/Ticket/Elements/EditBasics
+++ share/html/Ticket/Elements/EditBasics
@@ -85,12 +85,20 @@

  <tr>
      <td class="label"><&|/l&>Priority</&>:</td>
+% if ($RT::PriorityType) {
+ <td class="value"><&/Elements/SelectPriority, name=>"Priority", default=>$TicketObj->Priority &></td>
+% } else {
<td class="value"><input name="Priority" value="<%$TicketObj->Priority|h%>" size="5" /></td>
+% }
    </tr>

  <tr>
      <td class="label"><&|/l&>Final Priority</&>:</td>
+% if ($RT::PriorityType) {
+ <td class="value"><&/Elements/SelectPriority, name=>"FinalPriority", default=>$TicketObj->FinalPriority &></td>
+% } else {
<td class="value"><input name="FinalPriority" value="<%$TicketObj->FinalPriority|h%>" size="5" /></td>
+% }
    </tr>


--- share/html/Ticket/Elements/ShowBasics
+++ share/html/Ticket/Elements/ShowBasics
@@ -70,7 +70,11 @@
  </tr>
  <tr>
    <td class="label"><&|/l&>Priority</&>:</td>
+% if ($RT::PriorityType) {
+ <td class="value"><%$Ticket->PriorityAsString()%>/<%$Ticket->FinalPriorityAsString()%></td>
+% } else {
<td class="value"><%$Ticket->Priority%>/<%$Ticket->FinalPriority %></td>
+% }
  </tr>
  <tr>
    <td class="label"><&|/l&>Queue</&>:</td>
--- lib/RT/Ticket_Overlay.pm
+++ lib/RT/Ticket_Overlay.pm
@@ -3770,6 +3770,56 @@
    "RT::Queue-RT::Ticket";
}

+
+
+=head2 PriorityAsString
+
+ B<Returns> String: Various Ticket Priorities as either a string or integer
+
+=cut
+
+sub PriorityAsString {
+    my $self=shift;
+
+    unless ($self->CurrentUserHasRight('ShowTicket')) {
+        return undef;
+    }
+    return priorityString($self->Priority)
+}
+sub InitialPriorityAsString {
+    my $self=shift;
+
+    unless ($self->CurrentUserHasRight('ShowTicket')) {
+        return undef;
+    }
+    return priorityString($self->InitialPriority)
+}
+sub FinalPriorityAsString {
+    my $self=shift;
+
+    unless ($self->CurrentUserHasRight('ShowTicket')) {
+        return undef;
+    }
+    return priorityString($self->FinalPriority)
+}
+
+sub priorityString {
+    my $priority=shift;
+
+    if ( $RT::PriorityType ) {
+        foreach my $pridx ( @RT::PrioritySortedKeys ) {
+            if ( $priority >= $RT::PriorityLabels{ $pridx } ) {
+                return($pridx."/".$priority) if ( $RT::PriorityType != 1 );
+                return($pridx);
+            }
+        }
+        return "unknown";
+    }
+    return ($priority);
+}
+
+
+
1;

=head1 AUTHOR

_______________________________________________
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: [EMAIL PROTECTED]


Discover RT's hidden secrets with RT Essentials from O'Reilly Media. 
Buy a copy at http://rtbook.bestpractical.com

Reply via email to