On 05/01/2017 at 22:25:05 +0530, Bhumika Goyal wrote :
> Declare rtc_class_ops structures as const as they are only passed
> as an argument to the function devm_rtc_device_register. This argument
> is of type const struct rtc_class_ops *, so rtc_class_ops structures
> having this property can be declared const.
> Done using Coccinelle:
>
> @r1 disable optional_qualifier @
> identifier i;
> position p;
> @@
> static struct rtc_class_ops i@p = {...};
>
> @ok1@
> identifier r1.i;
> position p;
> @@
> devm_rtc_device_register(...,&i@p,...)
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct rtc_class_ops i;
>
> File size details:
>
> text data bss dec hex filename
> 559 320 0 879 36f drivers/rtc/rtc-dm355evm.o
> 671 192 0 863 35f drivers/rtc/rtc-dm355evm.o
>
> 4727 320 0 5047 13b7 drivers/rtc/rtc-imxdi.o
> 4855 192 0 5047 13b7 drivers/rtc/rtc-imxdi.o
>
> 1269 192 0 1461 5b5 drivers/rtc/rtc-mxc.o
>
> File size remains unchanged for : drivers/rtc/rtc-mxc.o
>
> Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
> ---
> drivers/rtc/rtc-dm355evm.c | 2 +-
> drivers/rtc/rtc-imxdi.c | 2 +-
> drivers/rtc/rtc-mxc.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
