The function is too complicated for gcc to realize that this variable does eventually get initialized, causing a harmless warning:
drivers/rtc/rtc-armada38x.c: In function 'read_rtc_register_wa': drivers/rtc/rtc-armada38x.c:131:25: warning: 'index_max' may be used uninitialized in this function [-Wmaybe-uninitialized] This adds an explicit initializion at the start of the function. I generally try to avoid that, but it seems appropriate here, as we start out with max=0 as well. Fixes: 61cffa2438e3 ("rtc: armada38x: Follow the new recommendation for errata implementation") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/rtc/rtc-armada38x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c index 6c9a2cbdc1a9..65e16965af7e 100644 --- a/drivers/rtc/rtc-armada38x.c +++ b/drivers/rtc/rtc-armada38x.c @@ -90,7 +90,7 @@ static void rtc_update_mbus_timing_params(struct armada38x_rtc *rtc) static u32 read_rtc_register_wa(struct armada38x_rtc *rtc, u8 rtc_reg) { - int i, index_max, max = 0; + int i, index_max = 0, max = 0; for (i = 0; i < SAMPLE_NR; i++) { rtc->val_to_freq[i].value = readl(rtc->regs + rtc_reg); -- 2.9.0 -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.