Mostly good, one nitpick: On 16/03/2017 at 13:51:08 -0400, Chris Brandt wrote: > res = platform_get_resource(pdev, IORESOURCE_IO, 0); > + if (res == NULL)
if (!res) is preferred here -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.