Hello,
Thanks for accepting this patch. I'll work on the guidelines given by you.
Before modifying the csb336 patch, and moving further with other bsps, Can I
consider the work for this bsp closed ?
Regards
Vipul Nayyar
________________________________
From: Sebastian Huber <[email protected]>
To: Vipul Nayyar <[email protected]>
Cc: Joel Sherrill <[email protected]>; "[email protected]"
<[email protected]>
Sent: Sunday, 7 July 2013 6:39 PM
Subject: Re: [Patch] Removing legacy method from arm csb337
Hello,
I checked in a slightly modified version:
http://git.rtems.org/rtems/commit/?id=6886a485301330b1347b89432b2c49287dc41010
Some remarks:
1. Please don't use
type func()
in C, use
type func(void)
instead.
2. Don't introduce trailing white space. You can use
git config --global --add diff.color auto
git config --global color.ui auto
to instruct Git to highlight this in "git diff" for you.
3. Use "git format-patch" to produce patches. You can use "git send-email" to
send this to the list. Example configuration:
git config --global --add sendemail.to [email protected]
git config --global --add sendemail.smtpserver your.server
git config --global --add sendemail.from 'Your Name <[email protected]>'
git config --global --add sendemail.suppresscc all
On 06/07/13 19:06, Vipul Nayyar wrote:
> Thanks for the advice. In fact I removed most of the warnings with the help
> of Google only in my earlier patch.
> I've checked and removed functions at91rm9200_emac_isr_off() &
> at91rm9200_emac_isr_is_on() since they're defined but not used.
> I've made phywrite() & phyread() static since they're not used anywhere else.
>
> But still I'm getting a warning saying : 'phyread' defined but not used
> [-Wunused-function] . Although it is used a couple of times in the file, but
> still I'm getting this warning. Maybe it has something to do with being a
> static function. Please try this patch.
It was used only if csb637 was defined.
-- Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : [email protected]
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
_______________________________________________
rtems-devel mailing list
[email protected]
http://www.rtems.org/mailman/listinfo/rtems-devel
