Hello,
I still get trailing white space errors from your patches:
git am \[PATCH\]\ Updated\ Legacy\ code\ in\ arm\ edb7312.eml
Applying: Updated Legacy code in arm edb7312
/home/sh/git-rtems/.git/rebase-apply/patch:131: trailing whitespace.
);
/home/sh/git-rtems/.git/rebase-apply/patch:144: trailing whitespace.
);
warning: 2 lines add whitespace errors.
On 07/09/2013 03:33 PM, Vipul Nayyar wrote:
[...]
@@ -37,9 +27,17 @@ rtems_irq_connect_data clock_isr_data = {
} while(0)
#define Clock_driver_support_install_isr( _new, _old ) \
+ rtems_status_code status = RTEMS_SUCCESSFUL; \
Why do you move this declaration out of the do { ... } while (0) scope?
do { \
(_old) = NULL; /* avoid warning */; \
- BSP_install_rtems_irq_handler(&clock_isr_data); \
+ status = rtems_interrupt_handler_install( \
+ BSP_TC1OI, \
+ "Clock", \
+ RTEMS_INTERRUPT_UNIQUE, \
+ Clock_isr, \
+ NULL \
+ ); \
+ assert(status == RTEMS_SUCCESSFUL); \
} while(0)
/*
[...]
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : [email protected]
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
_______________________________________________
rtems-devel mailing list
[email protected]
http://www.rtems.org/mailman/listinfo/rtems-devel
