If I don't need that intermediate variable, then my previous patch containing
void cs8900_isr(cs8900_device *cs){
cs8900_interrupt(LPC22xx_INTERRUPT_EINT2, cs);
}
,should be correct right ?
I followed the flow of bsp_interrupt_handler_dispatch() & where it leads, but
couldn't figure out much. Will try again tomorrow.
I still don't understand what mistake I'm doing regarding removing superfluous
entities from the code. :-(
Regards
Vipul Nayyar
________________________________
From: Sebastian Huber <[email protected]>
To: Vipul Nayyar <[email protected]>
Cc: "[email protected]" <[email protected]>
Sent: Saturday, 13 July 2013 1:00 AM
Subject: Re: [PATCH] Updated Legacy code in arm rtl22xx
On 12/07/13 17:30, Vipul Nayyar wrote:
> Ok, So before sending the updated patch I'll list in advance what I'm gonna
> change, so that we don't have to go through this again.
>
> 1) Change cs8900_isr to static. The sample code would be:
> static void cs8900_isr(void *arg)
> {
> cs8900_device *cs = arg;
> cs8900_interrupt(LPC22xx_INTERRUPT_EINT2, cs);
> }
This is all right in principle, but you don't need the intermediate
variable.
Now the questions are:
1. Who will call this function?
2. Where does the actual arg argument value come from?
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : [email protected]
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG._______________________________________________
rtems-devel mailing list
[email protected]
http://www.rtems.org/mailman/listinfo/rtems-devel
