Joel Sherrill wrote:
This warning is largely useless if you don't want that. That's mostly what it 
complains about.

But it does sometimes find something really wrong


Is 'bsp_clock_nanoseconds_since_last_tick' referenced outside of the file ? If yes then there needs to a header file and if no then why not make it static ?

Chris

Gedare Bloom<[email protected]>  wrote:


I dislike this prototype in a .c file especially just to satisfy
compiler warnings.

On Sep 22, 2013 11:52 AM, "Joel Sherrill" <[email protected]
<mailto:[email protected]>> wrote:

    Module: rtems
    Branch: master
    Commit: d2c5bff7dc5a93d5369e83e5c412c3b424dee781
    Changeset:
    
http://git.rtems.org/rtems/commit/?id=d2c5bff7dc5a93d5369e83e5c412c3b424dee781

    Author: Joel Sherrill <[email protected]
    <mailto:[email protected]>>
    Date: Sun Sep 22 10:51:36 2013 -0500

    leon3/.../ckinit.c: Fix missing prototype warnings

    ---

    c/src/lib/libbsp/sparc/leon3/clock/ckinit.c | 6 +++++-
    1 files changed, 5 insertions(+), 1 deletions(-)

    diff --git a/c/src/lib/libbsp/sparc/leon3/clock/ckinit.c
    b/c/src/lib/libbsp/sparc/leon3/clock/ckinit.c
    index 79f8864..8aa0af3 100644
    --- a/c/src/lib/libbsp/sparc/leon3/clock/ckinit.c
    +++ b/c/src/lib/libbsp/sparc/leon3/clock/ckinit.c
    @@ -37,7 +37,6 @@
    #define LEON3_CLOCK_INDEX 0
    #endif

    -
    volatile struct gptimer_regs *LEON3_Timer_Regs = 0;
    static int clkirq;

    @@ -94,6 +93,11 @@ static int clkirq;
    LEON3_Timer_Regs->timer[LEON3_CLOCK_INDEX].ctrl = 0; \
    } while (0)

    +/*
    + * Prototype to avoid warnings and body of get nanoseconds since
    last tick
    + */
    +uint32_t bsp_clock_nanoseconds_since_last_tick(void);
    +
    uint32_t bsp_clock_nanoseconds_since_last_tick(void)
    {
    uint32_t clicks;

    _______________________________________________
    rtems-vc mailing list
    [email protected] <mailto:[email protected]>
    http://www.rtems.org/mailman/listinfo/rtems-vc

_______________________________________________
rtems-devel mailing list
[email protected]
http://www.rtems.org/mailman/listinfo/rtems-devel
_______________________________________________
rtems-devel mailing list
[email protected]
http://www.rtems.org/mailman/listinfo/rtems-devel

Reply via email to