The one on datatracker has been trimmed to keep only the newer version. Regards,Reshad. ==============================================================================================================================================================================Update December 31st 2024 on draft-ietf-bfd-secure-sequence-numbers-18 ## Document History 1. Does the working group (WG) consensus represent the strong concurrence of a few individuals, with others being silent, or did it reach broad agreement?Strong consensus of a few individuals.The initial revision of this document is from 2017. Goal was to addressconcerns expressed by Security Area on the work to optimize BFD authentication(draft-ietf-bfd-optimizing-authentication). There have not been many commentson this document specifically, but there have been many discussions on what thisdocument provides in the context of draft-ietf-bfd-optimizing-authentication.Revision 9 of this document is the first one which mentions use of ISAAC. 2. Was there controversy about particular points, or were there decisions where the consensus was particularly rough?No controversy on this document. 3. Has anyone threatened an appeal or otherwise indicated extreme discontent? If so, please summarize the areas of conflict in separate email messages to the responsible Area Director. (It should be in a separate email because this questionnaire is publicly available.)No. 4. For protocol documents, are there existing implementations of the contents of the document? Have a significant number of potential implementers indicated plans to implement? Are any existing implementations reported somewhere, either in the document itself (as [RFC 7942][3] recommends) or elsewhere (where)?No implementations and no known plans to implement. ## Additional Reviews 5. Do the contents of this document closely interact with technologies in other IETF working groups or external organizations, and would it therefore benefit from their review? Have those reviews occurred? If yes, describe which reviews took place.No and no. 6. Describe how the document meets any required formal expert review criteria, such as the MIB Doctor, YANG Doctor, media type, and URI type reviews.N/A. 7. If the document contains a YANG module, has the final version of the module been checked with any of the [recommended validation tools][4] for syntax and formatting validation? If there are any resulting errors or warnings, what is the justification for not fixing them at this time? Does the YANG module comply with the Network Management Datastore Architecture (NMDA) as specified in [RFC 8342][5]?N/A. 8. Describe reviews and automated checks performed to validate sections of the final version of the document written in a formal language, such as XML code, BNF rules, MIB definitions, CBOR's CDDL, etc.N/A. ## Document Shepherd Checks 9. Based on the shepherd's review of the document, is it their opinion that this document is needed, clearly written, complete, correctly designed, and ready to be handed off to the responsible Area Director? The document is clearly written and nearly ready.There are some comments to be addressed before the document is handed off tothe responsible AD:https://mailarchive.ietf.org/arch/msg/rtg-bfd/d8V4BhioRGXmwGDZgqcO-rG9O7o/ 10. Several IETF Areas have assembled [lists of common issues that their reviewers encounter][6]. For which areas have such issues been identified and addressed? For which does this still need to happen in subsequent reviews? None. Note that SECDIR review is pending. 11. What type of RFC publication is being requested on the IETF stream ([Best Current Practice][12], [Proposed Standard, Internet Standard][13], [Informational, Experimental or Historic][14])? Experimental as indicated on title page. Why is this the proper type of RFC? Main reasons:- No known implementations- Not a lot of reviews on the latest revisions of the document Do all Datatracker state attributes correctly reflect this intent?Yes. 12. Have reasonable efforts been made to remind all authors of the intellectual property rights (IPR) disclosure obligations described in [BCP 79][7]? To the best of your knowledge, have all required disclosures been filed? If not, explain why. If yes, summarize any relevant discussion, including links to publicly-available messages when applicable.Yes. Waiting for response from 2 co-authors. 13. Has each author, editor, and contributor shown their willingness to be listed as such? Yes. If the total number of authors and editors on the front page is greater than five, please provide a justification.N/A. 14. Document any remaining I-D nits in this document. Simply running the [idnits tool][8] is not enough; please review the ["Content Guidelines" on authors.ietf.org][15]. (Also note that the current idnits tool generates some incorrect warnings; a rewrite is underway.)None. 15. Should any informative references be normative or vice-versa? See the [IESG Statement on Normative and Informative References][16].None. 16. List any normative references that are not freely available to anyone. Did the community have sufficient access to review any such normative references?None. 17. Are there any normative downward references (see [RFC 3967][9] and [BCP 97][10]) that are not already listed in the [DOWNREF registry][17]? If so, list them.None. 18. Are there normative references to documents that are not ready to be submitted to the IESG for publication or are otherwise in an unclear state? If so, what is the plan for their completion?None. 19. Will publication of this document change the status of any existing RFCs? If so, does the Datatracker metadata correctly reflect this and are those RFCs listed on the title page, in the abstract, and discussed in the introduction? If not, explain why and point to the part of the document where the relationship of this document to these other RFCs is discussed.No, this is an experimental document. 20. Describe the document shepherd's review of the IANA considerations section, especially with regard to its consistency with the body of the document. Confirm that all aspects of the document requiring IANA assignments are associated with the appropriate reservations in IANA registries. Confirm that any referenced IANA registries have been clearly identified. Confirm that each newly created IANA registry specifies its initial contents, allocations procedures, and a reasonable name (see [RFC 8126][11]).No IANA Considerations in this document since the relevant IANA Considerations are in draft-ietf-bfd-optimizing-authentication 21. List any new IANA registries that require Designated Expert Review for future allocations. Are the instructions to the Designated Expert clear? Please include suggestions of designated experts, if appropriate.None. [1]: https://www.ietf.org/about/groups/iesg/[2]: https://www.rfc-editor.org/rfc/rfc4858.html[3]: https://www.rfc-editor.org/rfc/rfc7942.html[4]: https://wiki.ietf.org/group/ops/yang-review-tools[5]: https://www.rfc-editor.org/rfc/rfc8342.html[6]: https://wiki.ietf.org/group/iesg/ExpertTopics[7]: https://www.rfc-editor.org/info/bcp79[8]: https://www.ietf.org/tools/idnits/[9]: https://www.rfc-editor.org/rfc/rfc3967.html[10]: https://www.rfc-editor.org/info/bcp97[11]: https://www.rfc-editor.org/rfc/rfc8126.html[12]: https://www.rfc-editor.org/rfc/rfc2026.html#section-5[13]: https://www.rfc-editor.org/rfc/rfc2026.html#section-4.1[14]: https://www.rfc-editor.org/rfc/rfc2026.html#section-4.2[15]: https://authors.ietf.org/en/content-guidelines-overview[16]: https://www.ietf.org/about/groups/iesg/statements/normative-informative-references/[17]: https://datatracker.ietf.org/doc/downref/ ======================================================================================= Previous writeup from 2024-06-14. (1) What type of RFC is being requested (BCP, Proposed Standard, Internet Standard, Informational, Experimental, or Historic)? Why is this the proper type of RFC? Is this type of RFC indicated in the title page header? Standards Track as indicated on title page. (2) The IESG approval announcement includes a Document Announcement Write-Up. Please provide such a Document Announcement Write-Up. Recent examples can be found in the "Action" announcements for approved documents. The approval announcement contains the following sections: Technical Summary:This document describes a security enhancement for the sequence number used in BFD control packets. Working Group Summary:Initial version of the document is from February 2017. Goal was to address concerns expressed by Security Area on the work to optimize BFD authentication (draft-ietf-bfd-optimizing-authentication).There have not been many comments on this draft specifically, but there have been many discussions on what this draft provides in the context of draft-ietf-bfd-optimizing-authentication. One action which has been postponed is updating the BFD YANG model to enable this functionality, this is needed also for draft-ietf-bfd-optimizing-authentication (although the latter requires a -bis of the BFD YANG document due to the new auth-type) Document Quality: Are there existing implementations of the protocol? Have a significant number of vendors indicated their plan to implement the specification? Are there any reviewers that merit special mention as having done a thorough review, e.g., one that resulted in important changes or a conclusion that the document had no substantive issues? If there was a MIB Doctor, YANG Doctor, Media Type or other expert review, what was its course (briefly)? In the case of a Media Type review, on what date was the request posted? The document is well-written, concise and technically accurate, but requires some editorial changes before being forwarded to the IESG. Personnel: Who is the Document Shepherd? Reshad Rahman, BFD co-chair. Who is the Responsible Area Director? Martin Vigoureux is the responsible AD. (3) Briefly describe the review of this document that was performed by the Document Shepherd. If this version of the document is not ready for publication, please explain why the document is being forwarded to the IESG. The shepherd has gone through the document, email archive and meeting minutes. Comments have been addressed. (4) Does the document Shepherd have any concerns about the depth or breadth of the reviews that have been performed? None. (5) Do portions of the document need review from a particular or from broader perspective, e.g., security, operational complexity, AAA, DNS, DHCP, XML, or internationalization? If so, describe the review that took place. This document arose from Security Area review of draft-ietf-bfd-optimizing-authentication. (6) Describe any specific concerns or issues that the Document Shepherd has with this document that the Responsible Area Director and/or the IESG should be aware of? For example, perhaps he or she is uncomfortable with certain parts of the document, or has concerns whether there really is a need for it. In any event, if the WG has discussed those issues and has indicated that it still wishes to advance the document, detail those concerns here. None. (7) Has each author confirmed that any and all appropriate IPR disclosures required for full conformance with the provisions of BCP 78 and BCP 79 have already been filed. If not, explain why?Yes (8) Has an IPR disclosure been filed that references this document? If so, summarize any WG discussion and conclusion regarding the IPR disclosures. No IPR disclosure (9) How solid is the WG consensus behind this document? Does it represent the strong concurrence of a few individuals, with others being silent, or does the WG as a whole understand and agree with it? WG consensus is solid. (10) Has anyone threatened an appeal or otherwise indicated extreme discontent? If so, please summarise the areas of conflict in separate email messages to the Responsible Area Director. (It should be in a separate email because this questionnaire is publicly available.) No (11) Identify any ID nits the Document Shepherd has found in this document. (See http://www.ietf.org/tools/idnits/ and the Internet-Drafts Checklist). Boilerplate checks are not enough; this check needs to be thorough. 1 comment about the document data being 106 days in the past.4 warnings about missing references for [O], [S], [A] and [H1] (mentioned but not defined). I think if e.g. <> is used instead of [] this warnings will go away. (12) Describe how the document meets any required formal review criteria, such as the MIB Doctor, YANG Doctor, media type, and URI type reviews. N/A (13) Have all references within this document been identified as either normative or informative? Yes (14) Are there normative references to documents that are not ready for advancement or are otherwise in an unclear state? If such normative references exist, what is the plan for their completion? No (15) Are there downward normative references references (see RFC 3967)? If so, list these downward references to support the Area Director in the Last Call procedure. None (16) Will publication of this document change the status of any existing RFCs? Are those RFCs listed on the title page header, listed in the abstract, and discussed in the introduction? If the RFCs are not listed in the Abstract and Introduction, explain why, and point to the part of the document where the relationship of this document to the other RFCs is discussed. If this information is not in the document, explain why the WG considers it unnecessary. No (17) Describe the Document Shepherd's review of the IANA considerations section, especially with regard to its consistency with the body of the document. Confirm that all protocol extensions that the document makes are associated with the appropriate reservations in IANA registries. Confirm that any referenced IANA registries have been clearly identified. Confirm that newly created IANA registries include a detailed specification of the initial contents for the registry, that allocations procedures for future registrations are defined, and a reasonable name for the new registry has been suggested (see RFC 8126). No protocol extensions which require a registry. (18) List any new IANA registries that require Expert Review for future allocations. Provide any public guidance that the IESG would find useful in selecting the IANA Experts for these new registries. N/A (19) Describe reviews and automated checks performed by the Document Shepherd to validate sections of the document written in a formal language, such as XML code, BNF rules, MIB definitions, YANG modules, etc.N/A (20) If the document contains a YANG module, has the module been checked with any of the recommended validation tools (https://trac.ietf.org/trac/ops/wiki/yang-review-tools) for syntax and formatting validation? If there are any resulting errors or warnings, what is the justification for not fixing them at this time? Does the YANG module comply with the Network Management Datastore Architecture (NMDA) as specified in RFC8342?N/A COMMENTS This document updates RFC5880. This is missing from the title page header. Abstracts/a security enhancements/a security enhancement/Suggestion: “This document describes a security enhancement for the sequence number used in BFD control packets”. Requirements LanguagePlease put this later in the document, e.g. after introduction. Add RFC8174, and add it as normative reference. IntroductionDon’t use Authentication TLV, instead use “Authentication Section”. E.g.s/in BFD authentication TLVs/in the BFD authentication section/
s/pseudo-random sequence numbers on the frame/pseudo-random sequence numbers in BFD control packets/I’m not sure I understood the last sentence starting with “Further security may be ….”. What is “resetting un-encrypted sequence”? Does it mean that when the sequence numbers rolls over, it’s reset to a pseudo-random number? Section 2Rename to “Theory of operation”Suggest splitting the 1st sentence, e.g. Instead of inserting a monotonically, sometimes occasionally, increasing sequence number in BFD control packets, a hash is inserted instead. The hash is computed, using a shared key, on the sequence number. That computed hash is then inserted into the sequence number field of the packet. In the following sentence, the part “used in computing an authenticated packet” is referring to computing the SHA1/MD5 hash/digest for the packet? That sentence should be clarified then. In case of BFD Authentication [I-D.ietf-bfd-optimizing-authentication], the sequence number used in computing an authenticated packet would be this new computed hash. Also, when referring to the optimization draft, better to use e.g. “optimized BFD authentication” than “BFD authentication”. The latter implies per-RFC5880 BFD authentication. s/psuedo/pseudo/s/ scope of this draft/ scope of this document/s/seuquence/sequence/ Not clear to me what the following means. Note: The first sequence number can be obtained using the same logic as the My Discriminator value. The diagram reads well for regular authentication. For secure sequence number, I think the diagram would gain clarity from an ordered list of steps on the sender and receiver. The current list before the diagram is useful, I believe the sender steps would start at “H1:” and the receiver steps at hash’. And yes, hash’ needs an explanation. On the receiver side, for validating that ’s’ is a good sequence number, the range has to be checked as mentioned in the previous paragraph. Section 5s/ stabiluty/ stability/s/admistratively/administratively/s/Sequential nature/The sequential nature/
