Dear Gabriele, Sounds great! Can you create a pull request? See here <https://guides.github.com/introduction/flow/> for some information if you need some. Simon
On Thu, Nov 21, 2019 at 5:38 PM <[email protected]> wrote: > Dear Simon, > > I have forked RTK and pushed a commit > <https://github.com/GabrieleBelotti/RTK/commit/cd8ef6dc31a987925949da01f4340810f3b85710> > which took all major changes from this commit > <https://github.com/SimonRit/RTK/commit/dc987fca11ae283b07547af19efcd26ad377a4da> > and > I hope I correctly added a RTK_USE_BUNZIP2 preprocessor option in > rtkConfiguration.h, and in the HncImageIO files. > I hope this is fine, I can’t test it with my current ITK build, but if > there’s something I missed or got wrong please let me know (I’m just a > newbie). > > Gabriele > > > > *Da:* Simon Rit <[email protected]> > *Inviato:* mercoledì 20 novembre 2019 11.37 > *A:* [email protected] > *Cc:* rtk-users <[email protected]> > *Oggetto:* Re: [Rtk-users] HNC reader > > > > I think I would first check if there is some code to bunzip on ITK's side > (it's not very clear from a quick search in the repo). > > If not, then I'll indeed create a cmake option (e.g., RTK_USE_BUNZIP2) and > include the code when activated. You can avoid compiling the cxx files from > cmake but you'll probably need a preprocessor option in rtkConfiguration.h > <https://github.com/SimonRit/RTK/blob/master/rtkConfiguration.h.in> (as > e.g. RTK_USE_CUDA). > > Don't hesitate to submit a work in progress as a PR if you need some help. > > Thanks! > > Simon > > > > On Wed, Nov 20, 2019 at 11:26 AM <[email protected]> > wrote: > > Thanks Simon! > I’m able to retrieve those codes for a start and that’s good! Currently > I’m using 1.4.0 so I don’t have to fiddle around too much. > How would you go for making the bzip2 dependency optional? Maybe creating > an option flag in CMake and editing the reader accordingly? > Gabriele > > > > *Da:* Simon Rit <[email protected]> > *Inviato:* mercoledì 20 novembre 2019 10.49 > *A:* [email protected] > *Cc:* rtk-users <[email protected]> > *Oggetto:* Re: [Rtk-users] HNC reader > > > > Hi, > > I think there's been a confusion on my side when writing the release notes > of RTK 1.4. I merged a pull request from Andreas Gravgaard who implemented > the Xim reader based on the Hnc reader. There is a commit > <https://github.com/SimonRit/RTK/commit/dc987fca11ae283b07547af19efcd26ad377a4da> > which includes Hnc but this other commit > <https://github.com/SimonRit/RTK/commit/9a1754f6e9f7d0257702fc9b48be724c74750990> > deleted it before merging. > > See the related PR <https://github.com/SimonRit/RTK/pull/72> and mailing > list conversation > <https://public.kitware.com/pipermail/rtk-users/2016-September/010334.html> > . > > We can probably include the reader in RTK if we can make the bzip2 > dependency optional using Geoff's code. > > Sorry for the mess, > > Simon > > > > On Wed, Nov 20, 2019 at 10:11 AM <[email protected]> > wrote: > > Dear RTK users, > > There is mentions of a .hnc reader in the 1.4.0 release ( > https://www.openrtk.org/RTK/news/201802_release1.4.php) but I can’t find > it linked in any version I tried (1.4.0 and 2.0.0/1). > I think this may be a mistake so I wanted to raise the issue. > > I hope this is useful for anyone other than me! > > Gabriele > > _______________________________________________ > Rtk-users mailing list > [email protected] > https://public.kitware.com/mailman/listinfo/rtk-users > >
_______________________________________________ Rtk-users mailing list [email protected] https://public.kitware.com/mailman/listinfo/rtk-users
