M. Koehrer wrote:
> Hi Jan,
> 
> enclosed is another patch the supports the rtnet routing considering the IP 
> source address.
> I have a used a couple of #ifdefs to switch between the standard and the 
> "new" behaviour.
> This seems to me clearer than using macros (to my opinion macros can be 
> extremely confusing...).

Really a matter of taste. The macro-way reduces the number of #ifdefs to
two occurrences: the prototype and the function definition. Granted, we
only have a few invocations here, but even those few places suffer with
respect to readability in my eyes.

> I have now also extended the rtroute del command to support a device there.

Ok, will see how to merge this and give feedback on the result then.

Thanks for the patch,

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to