Jan Kiszka wrote:
> James Kilts wrote:
>>> I'm fine with that script add-on, I would just call it "capturing mode"
>>> ("-c") as it does more that just enabling promisc in the RT-NICs.
>> Done.
>>
>>
>>> ...actually belongs here (because here we know that there is a 4-byte IP
>>> address at announce->addr).
>> Oops.  For performance (with multiple iterations of the loop) I
>> figured that doing it once would be better.  Although, if
>> announce->addr is not valid all of the time, then it's clearly not a
>> safe operation.  I've modified the code as you suggested.
>>
>>
>>> PS: Consider using git to ease your patch management.
>> This is being submitted from my home machine running Windows.  Three
>> patches ago, diff seemed like the obvious choice.  :-)
>>
> 
> The beginning is usually painful, and I can imagine using Windows as
> platform doesn't make this better :). But it pays off once you start
> juggling with a non-trivial amount of changes.
> 
> OK, the patches look good. I just need a short subject line per patch
> (short enough that it doesn't wrap).
> 

Fixed up manually and pushed the patches unchanged otherwise.

Thanks again,
Jan


Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
RTnet-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rtnet-developers

Reply via email to