> @Vit Ondruch <vondr...@redhat.com> - if you have any idea on why it can't find the binary path, that would be good, am I missing a requires on itself or some such?
It turns out this is an appropriate question for this list. Why is the following call failing inside the package build environment? Gem.bin_path 'asciidoctor-pdf', 'asciidoctor-pdf' Can we not rely on the Gem API? The build installs the gem before running the tests, so I don't see why this would fail. I'm willing to make certain accommodations in the test suite to get the tests passing, but using a workaround for this seems like a step too far. Best Regards, -Dan On Wed, May 6, 2020 at 4:10 AM Christopher Brown <chris.br...@redhat.com> wrote: > Dan, > > Thanks for looking into this - have patched and tested and looks good: > > https://kojipkgs.fedoraproject.org//work/tasks/1299/44151299/build.log > > @Vit Ondruch <vondr...@redhat.com> - if you have any idea on why it can't > find the binary path, that would be good, am I missing a requires on itself > or some such? > > Cheers > Chris > > On Tue, 5 May 2020 at 20:32, Dan Allen <dan.j.al...@gmail.com> wrote: > >> Christopher, >> >> I discovered the issue. Fedora uses a new version of the pdf-core gem >> (0.8.1) than what prawn requests (0.7.0). There was a change introduced in >> that version to truncate any float value in the PDF to an integer if the >> decimal is zero. See >> https://github.com/prawnpdf/pdf-core/commit/3bea761521b3483e1e81968c600b6fddf6a87863. >> That's why we're seeing differences in the test results when comparing the >> page dimensions. >> >> I'll make the change to the test suite with a note that the comparison >> must not assume the numeric type. >> >> -Dan >> >> On Tue, May 5, 2020 at 9:11 AM Christopher Brown <chris.br...@redhat.com> >> wrote: >> >>> Hi there, >>> >>> I have bumped the version of a package I maintain in Fedora and am >>> seeing an increase in errors from the test suite run. >>> >>> https://kojipkgs.fedoraproject.org//work/tasks/6453/44116453/build.log >>> >>> I'm specifically trying to understand the errors regarding being unable >>> to locate the binary and the eql errors as these form the majority. >>> >>> I have asked about the latter upstream a while back: >>> >>> https://github.com/asciidoctor/asciidoctor-pdf/issues/1542 >>> >>> and received comment about there possibly being a problem with rspec >>> itself? >>> >>> Any advice appreciated. >>> >>> -- >>> Christopher Brown >>> _______________________________________________ >>> ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org >>> To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org >>> Fedora Code of Conduct: >>> https://docs.fedoraproject.org/en-US/project/code-of-conduct/ >>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >>> List Archives: >>> https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org >>> >> >> >> -- >> Dan Allen | @mojavelinux | https://twitter.com/mojavelinux >> _______________________________________________ >> ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org >> To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org >> Fedora Code of Conduct: >> https://docs.fedoraproject.org/en-US/project/code-of-conduct/ >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >> List Archives: >> https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org >> > > > -- > Christopher Brown > Senior Consultant > Red Hat UK Ltd > chris.br...@redhat.com > _______________________________________________ > ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org > To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org > -- Dan Allen | @mojavelinux | https://twitter.com/mojavelinux
_______________________________________________ ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org
