Christopher, I understand your point. But please consider the fact that many of the diagramming tool integrations that Asciidoctor Diagram provides are optional (and thus there is no reason to bundle them). If the tool is not there, then it simply cannot be used in the document. The "core" ones are graphviz, plantuml, and blockdiag, which are already packaged for Fedora. I would focus on those to start. Worry about the long tail later (if ever).
Best Regards, -Dan On Mon, Nov 2, 2020 at 8:41 AM Christopher Brown <chris.br...@redhat.com> wrote: > Hi Dan, > > Thanks for this. The issue I think is that there is a large number of > dependencies and AIUI, Fedora doesn't allow these to be bundled with the > gem[1]. This means a fairly significant task creating packages for a > variety of nodejs dependencies amongst other things, e.g. Vega[2] has a > fairly rapid release schedule. > > The more I consider the situation, the more I'm thinking that rpm is not > the correct packaging format for asciidoctor-pdf and friends given their > long list of dependencies and that a better fit would be a containerised > deployment or perhaps flatpak/snap. > > However I thought I'd put this out for further responses from anyone with > a vested interest. > > 1. > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries > 2. https://github.com/vega/vega/tags > > > On Thu, 29 Oct 2020 at 20:28, Dan Allen <dan.j.al...@gmail.com> wrote: > >> Christopher, >> >> I would encourage you not to give up on Asciidoctor Diagram yet. I spoke >> with Pepijn (https://github.com/pepijnve), the maintainer, and he told >> me he would be glad to help you if you reached out (via the project issue >> tracker). Just introduce yourself there so he knows who you are. He said he >> is willing to change the code or build if necessary to get it packaged. >> >> Although Asciidocotor Diagram bundles some of the diagram tools in the >> published gem, it could be reconfigured / patched to look for those tools >> from another place on the system. The only requirement is that it finds the >> tool somewhere on the system so it can be invoked. >> >> Best Regards, >> >> -Dan >> >> On Tue, Oct 27, 2020 at 11:38 AM Christopher Brown < >> chris.br...@redhat.com> wrote: >> >>> Ok, thanks Vit. >>> >>> I think I'll probably do the same. >>> >>> I don't have the bandwidth to take on the maintenance of that number of >>> packages right now unless anyone else is interested in sharing the work? >>> >>> On Tue, 27 Oct 2020 at 16:52, Vít Ondruch <vondr...@redhat.com> wrote: >>> >>>> When we tried to get ascii_binder into Fedora, we get this far with >>>> asciidoctor-diagram. >>>> >>>> >>>> https://fedorapeople.org/cgit/jackorp/public_git/rubygem-asciidoctor-diagram.git/tree/rubygem-asciidoctor-diagram.spec >>>> >>>> But we rather avoided the dependency in ascii_binder for the time being: >>>> >>>> >>>> https://src.fedoraproject.org/rpms/rubygem-ascii_binder/blob/0d17b858e07ea9dca5a18f9f39554ef586caa883/f/rubygem-ascii_binder.spec#_45 >>>> >>>> >>>> Vít >>>> >>>> >>>> Dne 27. 10. 20 v 17:31 Christopher Brown napsal(a): >>>> >>>> Hello, >>>> >>>> I've upgrade to F33 and discovered that we are missing >>>> asciidoctor-diagram as a requirement for some internal tooling. >>>> >>>> https://rubygems.org/gems/asciidoctor-diagram/ >>>> https://github.com/asciidoctor/asciidoctor-diagram >>>> >>>> I am putting together a spec file for this now however tests are >>>> failing with missing executables in the path. I am able to work around some >>>> by installing the package but the majority we don't appear to ship packages >>>> for - see example below. >>>> >>>> Again, I'm sure this is something obvious (hopefully) and would >>>> appreciate a steer in the right direction. I've attempted to pass various >>>> options to rspec but to no avail. >>>> >>>> Thanks for any advice in advance. >>>> >>>> 425) Asciidoctor::Diagram::WavedromBlockProcessor should support >>>> scaling diagrams >>>> Failure/Error: raise "Could not find the #{cmd_names.map { |c| >>>> "'#{c}'" }.join(', ')} executable in PATH; add it to the PATH or specify >>>> its location using the '#{attr_names[0]}' document attribute" >>>> >>>> RuntimeError: >>>> asciidoctor: FAILED: <stdin>: Failed to load AsciiDoc document >>>> - Could not find the 'WaveDromEditor' executable in PATH; add it to the >>>> PATH or specify its location using the 'WaveDromEditor' document attribute >>>> Shared Example Group: "block" called from >>>> ./spec/wavedrom_spec.rb:16 >>>> # ./lib/asciidoctor-diagram/diagram_source.rb:130:in >>>> `find_command' >>>> # ./lib/asciidoctor-diagram/wavedrom/converter.rb:39:in `convert' >>>> # ./lib/asciidoctor-diagram/diagram_processor.rb:170:in >>>> `create_image_block' >>>> # ./lib/asciidoctor-diagram/diagram_processor.rb:86:in `process' >>>> # >>>> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in >>>> `[]' >>>> # >>>> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in >>>> `build_block' >>>> # >>>> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:886:in >>>> `next_block' >>>> # >>>> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:379:in >>>> `next_section' >>>> # >>>> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:364:in >>>> `next_section' >>>> # >>>> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:97:in >>>> `parse' >>>> # >>>> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/document.rb:549:in >>>> `parse' >>>> # >>>> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/load.rb:83:in >>>> `load' >>>> # ./spec/test_helper.rb:70:in `load_asciidoc' >>>> # ./spec/shared_examples.rb:592:in `block (2 levels) in <top >>>> (required)>' >>>> # ./spec/test_helper.rb:112:in `block (3 levels) in <top >>>> (required)>' >>>> # ./spec/test_helper.rb:111:in `chdir' >>>> # ./spec/test_helper.rb:111:in `block (2 levels) in <top >>>> (required)>' >>>> # ------------------ >>>> # --- Caused by: --- >>>> # RuntimeError: >>>> # Could not find the 'WaveDromEditor' executable in PATH; add >>>> it to the PATH or specify its location using the 'WaveDromEditor' document >>>> attribute >>>> # ./lib/asciidoctor-diagram/diagram_source.rb:130:in >>>> `find_command' >>>> >>>> -- >>>> Christopher Brown >>>> >>>> >>>> _______________________________________________ >>>> ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org >>>> To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org >>>> Fedora Code of Conduct: >>>> https://docs.fedoraproject.org/en-US/project/code-of-conduct/ >>>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >>>> List Archives: >>>> https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org >>>> >>>> _______________________________________________ >>>> ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org >>>> To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org >>>> Fedora Code of Conduct: >>>> https://docs.fedoraproject.org/en-US/project/code-of-conduct/ >>>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >>>> List Archives: >>>> https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org >>>> >>> >>> >>> -- >>> Christopher Brown >>> Senior Consultant >>> Red Hat UK Ltd >>> chris.br...@redhat.com >>> _______________________________________________ >>> ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org >>> To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org >>> Fedora Code of Conduct: >>> https://docs.fedoraproject.org/en-US/project/code-of-conduct/ >>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >>> List Archives: >>> https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org >>> >> >> >> -- >> Dan Allen (he, him, his) | @mojavelinux | https://twitter.com/mojavelinux >> _______________________________________________ >> ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org >> To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org >> Fedora Code of Conduct: >> https://docs.fedoraproject.org/en-US/project/code-of-conduct/ >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >> List Archives: >> https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org >> > > > -- > Christopher Brown > Senior Consultant > Red Hat UK Ltd > chris.br...@redhat.com > _______________________________________________ > ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org > To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org > -- Dan Allen (he, him, his) | @mojavelinux | https://twitter.com/mojavelinux
_______________________________________________ ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org
