Dne 27. 09. 21 v 19:38 Otto Urpelainen napsal(a):
Hello Ruby SIG,

Jekyll 4.2.1 was recently released [1]. Consequently, I am working on updating the Fedora rubygem-jekyll package. Even though the update is a small bugfix release, various parts of the specfile that worked for 4.2.0 now fail.


Could you please be more specific, e.g. provide us with build.log or so?


I have determined the reason for those changes is that the files inside jekyll 4.2.1 gem have CRLF line endings.


This seems strange. Was there really some change like this in upstream? Then it should be possible to understand the reason for such change from Git log, but I can't find such change in Git neither I can see CRLF in e.g. https://raw.githubusercontent.com/jekyll/jekyll/master/lib/jekyll.rb. Therefore I suspect that this might be release engineering issue. Somebody released the gem from Windows where it previously was released from Linux. This is something upstream should address.


Vít





I can fix the problems by converting selected files to LF as follows:

    BuildRequires: dos2unix

    %prep
    ...
    dos2unix lib/jekyll/commands/new.rb
    dos2unix exe/jekyll

However, I am unsure if this is a good way to proceed. Should I convert *all* the files inside the gem, so that no CRLF files are installed to user systems, potentially causing more problems later? Or should I try to convince the upstream to move back to publishing their gem with LF?

Any advice is welcome.

Otto

[1]: https://rubygems.org/gems/jekyll/versions/4.2.1
_______________________________________________
ruby-sig mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
_______________________________________________
ruby-sig mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to