On Tue, Feb 19, 2013 at 12:47 AM, Joel Pearson <[email protected]> wrote:
> After more face-to-keyboard action, I came up with a working filter > system. it modifies self at the moment rather than returning a copy, > which is something I'll have to look intosince I'm not sure I want that > to be the default behaviour. You cannot change self. Or do you mean you change matrix contents? IMHO that's a bad idea since you basically only want a filtered /view/ on the data. > I've added a index option for row and column, and also added row and > column methods to String. Since those methods didn't exist before, and > you gave me the idea of modifying an existing class (Regexp), I thought > this would be quite a useful way to get the index values straight from > the hash keys. IMHO that is not a good idea. The method I suggested for Regex is of general use because matching is what Regex instances are for. But the extraction of a row or column identifier is closely bound to your class's logic. So if at all I'd put it as a class method in class RubyExcel. > ... > I'm too tired for rational thought now so I'd better call it a day > before I find myself thinking that adding ASCII art comments in the > shape of ponies and rainbows would improve the code... :-) Frankly, I don't have the time right now to take a closer look. I hope I can followup at a later point in time. Kind regards robert -- remember.guy do |as, often| as.you_can - without end http://blog.rubybestpractices.com/ -- [email protected] | https://groups.google.com/d/forum/ruby-talk-google?hl=en --- You received this message because you are subscribed to the Google Groups "ruby-talk-google" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
