On Sun, Feb 14, 2010 at 2:10 PM, Luis Lavena <[email protected]> wrote: > On Sun, Feb 14, 2010 at 7:40 PM, Nick Quaranto <[email protected]> wrote: >> Alright, I dragged out my Dell laptop with Vista and saw some failures as >> well, patched them up here: >> >> http://github.com/qrush/rubygems/commits/fix_api_key >> http://github.com/qrush/rubygems/compare/b4c556b...fix_api_key >> >> I'm skipping the sign in tests for Windows, but I've tested that out on my >> Dell laptop and it seems alright. It's also the exact same code from the >> heroku gem, so it should be fine. >> >> There seems to be some other failures on Windows too but these changes fix >> the problems related to Gemcutter stuff. >> > > Going to take a look first thing Monday (CET). > > Skipping tests for a functionality that will be used by Windows users > just give me the chills. > > Will check them tomorrow morning and maybe commit the proper changes. > Been a while since tested RubyGems...
Right, I definitely think we ought to look into these, not just skip them. Could it be as simple as a line ending issue? Regards, Dan _______________________________________________ Rubygems-developers mailing list http://rubyforge.org/projects/rubygems [email protected] http://rubyforge.org/mailman/listinfo/rubygems-developers
