On Wed, Aug 15, 2007 at 11:27:53AM +1200, Michael Koziarski wrote: > > I've just been stung by #6353 (http://dev.rubyonrails.org/ticket/6353; > > "Undefined method recycle! in integration test with put or delete") in a > > Rails 1.2.3 project (specifically, I'm using form_test_helper, but it seems > > more general than that). The problem has been solidly fixed in edge, but > > I'm wondering if it's worth backporting the fix to stable. > > Yes, if you feel the fix warrants backporting just reopen the ticket > once you've managed to back port the fix. Most of the time the > backport is simple enough, but some areas have received significant > changes in edge.
The patches I'm looking at (so far) apply trivially and DTRT. If there are patches that aren't clean, then they'll obviously need to be cleaned up before they can be applied. > > (No, upgrading > > world+dog to edge is *not* an option). > > Agreed. I added that because so often the answer given by projects to "these bugs $are in STABLE" is "upgrade to $BLEEDING_EDGE". > > What's the procedure to make that happen? Reopen the ticket, set the > > version to 1.2.3, and comment saying that it needs application to stable? > > Presumably I'd need to supply a patch that works against stable, which I'm > > happy to do. Should I make sure other people believe the patch is worth > > going into stable by discussing it here before doing that? > > Generally we'll backport any bug fixes without much objection. The > only cases where that won't happen are where the bug was fixed as a > result of some heavy-duty changes to a given area of the codebase. > However if another fix can be found, there's no reason not to apply > that. Okie. One question I forgot to ask before -- do we go through the +1 process/verified process, or do I just set 'verified' immediately to get it into the verified report (on the basis that, if the fix went into edge, the patch is probably OK)? Should there be (is there) a tag specifically for "this needs to be applied to the stable branch"? Nothing jumped out at me in http://dev.ror.o/reports. > On another note, it's about time to get serious about releasing > another 1.2.x, but before we do that we should get an idea of what > other fixes warrant backports, and get patches ready for that. > Perhaps some of the participants in this thread could spend some time > reviewing the changelogs / timeline and figuring out which fixes > they'd like to see merged. I'm happy to handle committing all the > patches and reviewing them, but as I've been on edge for some time, > I'm certainly not the right person to know what's still annoying 1.2.x > developers. I'll see what I can do in that line, but others should probably chip in their favourites as well. - Matt --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
