Thanks to the great suggestions both here and in #rails-contrib, I'm working on a slightly different angle to this patch. Hopefully I'll have the code finished in another day or two to post up here for review, but hopefully I can address
the many legitimate concerns that have been raised.
- David On Jul 22, 2008, at 10:30 AM, James Golick wrote:
There's actually a somewhat major issue with this patch, with respect to multi-model forms. Because the elements are submitted as an array [{}, {}, {}], they are completely incompatible with ajax submissions of forms. When rails receives params in an array format (param[]), it reads each element in the order it receives it, until it reaches a duplicate key, that's when it decides to create a new element in the array that your controller ultimately sees. When forms are submitted via ajax, it isn't really feasible to make sure that elements are submitted in order. This is partly why I wrote attribute_fu, even when Ryan Bates' solution was wrapped up in the multi-model forms plugin. The hash that a_f generates is ugly, but it works in all cases. This patch, unless amended to support those ugly hashes instead, is going to cause people a lot of headache when they can't figure out why their ajax forms won't save right. Or worse, when the attributes are all getting crossed up between the different elements. On Jul 22, 6:38 am, raffael <[EMAIL PROTECTED]> wrote:Sorry for a little off-topic but does anyone of know how to support anobject that inherits all attributes through STI when I use :accessible=>true? For example: Object A belongs_to object B and B has_many A objects. Object B is accessible for A. Objects C and D inherit their fields through STI from the B object. I want to create a form that will allow me to fill object's A fields along with C or D's fields. The form should have a type selector so that user can choose if he wants to fill a C object or D. Form has: - object A fields - choose object type list- depending on the type selected in the list above a set of fields fora specific B inheriting object (C or D)--~--~---------~--~----~------------~-------~--~----~You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
smime.p7s
Description: S/MIME cryptographic signature