>I'm not a fan of the platform/implementation conditions. When I did >the SQL Server adapter, I found it very easy to use ruby to coerce the >tests that I needed to. See the links below and you can see how I did >this with a simple method_added hook. This leaves core to do what they >want and focus on corey things and we can use ruby to do what we need >to :) > >http://github.com/rails-sqlserver/2000-2005-adapter/tree/master >http://github.com/rails-sqlserver/2000-2005-adapter/tree/master/test/cases/sqlserver_helper.rb#L41
Thanks for the comments Ken, I like the fact that your implementation doesn't touch the rails code. I don't like that it needs to be in a plugin relationship to rails. Do you think the same result could be done in a gem install? I don't have an sqlserver to test your code on but tell me if I've got this right: Here's how to run the all the Ar tests for sqlsever: cd activerecord rake test_sqlserver This runs all the AR tests on the sqlserver server ... except where an original test like this: migration_test.rb has a matching test in your test/cases dir with the adapter name suffixed on the name of the test: migration_test_sqlserver.rb You have 16 test files in your cases dir -- it looks like most of them reflect tests in the AR test/cases dir -- except for: aaaa_create_tables_test_sqlserver.rb which has one extra 'a' compared to the AR test: aaa_create_tables_test.rb This mean you need to track functional changes in the AR tests and port them over to your test suite. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
