>> - Make :include *always* use preload strategy unless the required data set
>> is explicitly loaded
>>
With that you mean that it's not going to interpret the select, order
and condition strings anymore to determine if they're referencing some
table? I'd be all for that! The interpretation of those string
currently uses a too simple heuristic and is therefor just not working
in practice.
>> - Introduce :left_joins and :right_joins keys to the finder. Title says it
>> all
>>
+1. Though I prefer the terms :left_outer_joins and :right_outer_joins.
For completeness sake also introduce :full_outer_joins.
>> - Make user explicitly specify the required joins if they want to put
>> conditions on the associations
>> - For all the associations specified in :include, check if the required
>> dataset has already been loaded by :*joins. If not, preload.
>>
I guess this means that the :joins method will no longer accept a
string? (or if they will, then a string value will be ignored to
determine if preloading must occur or not)
> Sounds good to me, but I also like the idea of being able to do something
> like
>
> @orders = Order.find_by_sql(CRAZY_SHIT)
> @orders.preload(:line_items=>{:sku=>:title})
>
+1 on a public preload method as well.
Cheers,
Lawrence
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby
on Rails: Core" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---
