I can't speak for the rest of the core team, but I personally am keeping a close eye on pull requests, which are much easier for me to work through than dealing with patches on LH (which require saving the patch, seeing if it applies, then reviewing, etc. etc.). Pull requests telescope the first 5 or 6 steps of reviewing patches on LightHouse into one step.
Yehuda Katz Architect | Engine Yard (ph) 718.877.1325 On Sat, Sep 11, 2010 at 2:13 PM, Teng Siong Ong <siong1...@gmail.com> wrote: > pull request sent. > > side note: i actually asked this question in the irc channel, in future, > should we keep using the old school patch way or the github pull request way > to patch? > > siong. > > > On Sat, Sep 11, 2010 at 12:08 PM, radhames brito <rbri...@gmail.com>wrote: > >> Great!!! >> >> >> On Sat, Sep 11, 2010 at 4:22 AM, Yehuda Katz <wyc...@gmail.com> wrote: >> >>> Can you submit this as a pull request on GitHub? >>> >>> Yehuda Katz >>> Architect | Engine Yard >>> (ph) 718.877.1325 >>> >>> >>> >>> On Sat, Sep 11, 2010 at 2:30 AM, Teng Siong Ong <siong1...@gmail.com>wrote: >>> >>>> patch added: >>>> https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5613-adding-j-parameter-for-rails-new-command >>>> >>>> for this patch, i removed the usual "--skip-prototype" parameter and >>>> substituted it with the "--skip-javascript" parameter. then, i added a new >>>> "-j" or "--javascript" parameter. this parameter accepts either "jquery" or >>>> "prototype". >>>> >>>> btw, the default javascript library now is still "prototype". >>>> siong. >>>> >>>> >>>> On Fri, Sep 10, 2010 at 9:06 PM, Teng Siong Ong <siong1...@gmail.com>wrote: >>>> >>>>> how others think about it? if someone from the core team could verity >>>>> this issue, i will go ahead and implement it. >>>>> >>>>> >>>>> On Fri, Sep 10, 2010 at 6:50 PM, Lailson Bandeira <lailso...@gmail.com >>>>> > wrote: >>>>> >>>>>> This would be great! >>>>>> -- >>>>>> LAILSON BANDEIRA >>>>>> http://lailsonbandeira.com/ >>>>>> >>>>>> >>>>>> >>>>>> On Fri, Sep 10, 2010 at 7:31 PM, siong1987 <siong1...@gmail.com>wrote: >>>>>> >>>>>>> so, for now, we have a "-d" parameter when starting up a new Rails >>>>>>> application with options like "mysql", "sqlite3", etc. >>>>>>> >>>>>>> do you all think that is it a good idea to have a "-j" parameter that >>>>>>> could get options like "jquery" and "prototype" so that the preferred >>>>>>> javascript library is used when starting up a new Rails app? >>>>>>> >>>>>>> siong. >>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "Ruby on Rails: Core" group. >>>>>>> To post to this group, send email to >>>>>>> rubyonrails-c...@googlegroups.com. >>>>>>> To unsubscribe from this group, send email to >>>>>>> rubyonrails-core+unsubscr...@googlegroups.com<rubyonrails-core%2bunsubscr...@googlegroups.com> >>>>>>> . >>>>>>> For more options, visit this group at >>>>>>> http://groups.google.com/group/rubyonrails-core?hl=en. >>>>>>> >>>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Ruby on Rails: Core" group. >>>>>> To post to this group, send email to >>>>>> rubyonrails-c...@googlegroups.com. >>>>>> To unsubscribe from this group, send email to >>>>>> rubyonrails-core+unsubscr...@googlegroups.com<rubyonrails-core%2bunsubscr...@googlegroups.com> >>>>>> . >>>>>> For more options, visit this group at >>>>>> http://groups.google.com/group/rubyonrails-core?hl=en. >>>>>> >>>>> >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Ruby on Rails: Core" group. >>>> To post to this group, send email to rubyonrails-c...@googlegroups.com. >>>> To unsubscribe from this group, send email to >>>> rubyonrails-core+unsubscr...@googlegroups.com<rubyonrails-core%2bunsubscr...@googlegroups.com> >>>> . >>>> For more options, visit this group at >>>> http://groups.google.com/group/rubyonrails-core?hl=en. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "Ruby on Rails: Core" group. >>> To post to this group, send email to rubyonrails-c...@googlegroups.com. >>> To unsubscribe from this group, send email to >>> rubyonrails-core+unsubscr...@googlegroups.com<rubyonrails-core%2bunsubscr...@googlegroups.com> >>> . >>> For more options, visit this group at >>> http://groups.google.com/group/rubyonrails-core?hl=en. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To post to this group, send email to rubyonrails-c...@googlegroups.com. >> To unsubscribe from this group, send email to >> rubyonrails-core+unsubscr...@googlegroups.com<rubyonrails-core%2bunsubscr...@googlegroups.com> >> . >> For more options, visit this group at >> http://groups.google.com/group/rubyonrails-core?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-c...@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscr...@googlegroups.com<rubyonrails-core%2bunsubscr...@googlegroups.com> > . > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-c...@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
