I just submitted a PR for this: https://github.com/rails/rails/pull/20883
Thanks everyone for your comment. -Prem On Tue, Jul 14, 2015 at 4:13 PM Ufuk Kayserilioglu <u...@paralaus.com> wrote: > +1 > > There is even a name for that "magic `true`" parameter: "The Boolean Trap" > http://ariya.ofilabs.com/2011/08/hall-of-api-shame-boolean-trap.html > > > Ufuk Kayserilioglu > > On Tue, Jul 14, 2015 at 12:02 AM, Prem Sichanugrist <sikand...@gmail.com> > wrote: > >> How do you guys feel about adding support for passing `reload: true` >> instead of just `true` to force reload the association? >> >> I like the idea of that just because it removes a mystery attribute — you >> now know why you are passing an argument to that method, instead of passing >> a magic `true`. However, it's definitely longer to type compared to just >> `true`. >> >> We had some change like this before with `save(false)` where we promoted >> `save(validate: false)` instead. >> >> Do you think it's a good idea? Should I add support for it? >> >> -Prem >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to rubyonrails-core+unsubscr...@googlegroups.com. >> To post to this group, send email to rubyonrails-core@googlegroups.com. >> Visit this group at http://groups.google.com/group/rubyonrails-core. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscr...@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at http://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at http://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/d/optout.
