I already asked a question about refactoring `record.associations(true)` -> 
`record.associations(reload: true)` here: 
https://groups.google.com/forum/#!topic/rubyonrails-core/f756F2DLuG0

However, Eugene raises an interesting question in the PR 
(https://github.com/rails/rails/pull/20883#issuecomment-121419119) that it 
might actually make sense to just deprecate the support for 
`record.associations(true)`, and asks user to do 
`record.associations.reload` instead.

I think it make sense, but I want to hear how people think first. 
Internally, it actually does the same thing because the current association 
reader code actually calls `#reload` internally as well.

So, do you think it's a good idea to just deprecate and later remove the 
support for `record.associations(true)` instead?

Thanks,
Prem

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.

Reply via email to