I don't think we gain by moving this configuration to an ENV. There are no passwords present here, so hiding info about production isn't appealing in my view. Further more, REDIS_URL implies that your production environment just has a single Redis instance. Lots of deployments use several. So in short, I think this will make things a bit more complicated for people starting out and I think it wouldn't be a good fit for a lot of real deployments anyway.
Thanks for taking the time to propose this, though! We should always be thinking about and questioning our choices. On Tuesday, May 24, 2016 at 12:59:01 AM UTC+2, d...@omnidev.co.uk wrote: > > *config/cable.yml* > > *Desired implementation* > production: > adapter: redis > url: <%= ENV["REDIS_URL"] %> > > *Actual implementation* > production: > adapter: redis > url: redis://localhost:6379/1 > > > *Why?* > 1) In real life, most instances won't be using a locally hosted version of > redis > 2) Always better to hide info about production > 3) Will more easily integrate with third party software > > Let me know your thoughts > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at https://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/d/optout.
