I often join with a comma, so having a period at the end would break that. But having it be an option wouldn't be a bad thing. On Fri, Jun 24, 2016 at 12:04 AM Victor Ng KP <khuenp...@gmail.com> wrote:
> From UX perspective, a full sentence is to end with a period (see > http://ux.stackexchange.com/questions/18671/), but this is not the case > with Rails. In > https://github.com/rails/rails/blob/master/activemodel/lib/active_model/locale/en.yml, > we see that error messages are left hanging. > > > If the community agrees that we should add period at the end of error > message in ActiveModel (and everywhere else where applicable), please +1, > then I shall make a PR. > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-core+unsubscr...@googlegroups.com. > To post to this group, send email to rubyonrails-core@googlegroups.com. > Visit this group at https://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at https://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/d/optout.
