I think that the IE-issues are there regardless of your patch. At least the tests are failing for me without it too.
On IE7 there will be issues with the tests when using the XHR on a local file: URL, like the relative ones in the ajax.html tests, because the new native IE7 XHR-object will not allow request to local url:s. The tests will run if the ActiveX XHR-object is loaded for all IE versions, but I don't think this is a good solution since there seem to be yet other issues with the ActiveX-object and IE7, and the Native IE7-object should be used. The test for Ajax.Responders will fail even using the ActiveX object, and from what I can tell, the two failed test there happen because IE and firefox seem to fire readystatechanges for readyState 4 at different times. I'm not sure this is much of an issue though, and maybe the tests should be changed to reflect this? Matti Ryhänen On 1/25/07, tobie <[EMAIL PROTECTED]> wrote: > > > Patch: http://dev.rubyonrails.org/ticket/7295 > > and live tests: > http://sandbox.tobielangel.com/prototype/rev_6028/trunk/test/unit/string.html > > > http://sandbox.tobielangel.com/prototype/rev_6028/trunk/test/unit/ajax.html > > I'm having issues in IE (don't know if its the actual code or the > testing that is causing the problem). > > The JSON sanitazing regex is taken from http://www.json.org/json.js > with permission from Douglas Crockford. > > Would like to get as much feedback as possible so we can make it really > bulletproof. > > Thanks, > > Tobie > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
