On 29 August 2015 at 16:08, tamouse pontiki <tamouse.li...@gmail.com> wrote: > can you memoize the result of test? assuming it wouldn't change between > callbacks? otherwise, write one callback and perform all the tests, > including the action check for only show inside it?
Yes I could do either of those but neither is aesthetically pleasing, which is why I wondered whether there was a better solution. Will probably plump for the first as the second filter would have to be called something like f1_unless_test_and_f2_if_show_unless_test for it to make any sense when read as f1 and f2 are unrelated. Colin > > On Sat, Aug 29, 2015 at 9:09 AM, Colin Law <clan...@gmail.com> wrote: >> >> Is there a more efficient way of coding this? >> >> before_filter :f1, unless: :test? >> before_filter :f2, only: :show, unless: :test? >> >> I don't want to call test? twice as it is not trivial. >> >> Colin >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Talk" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to rubyonrails-talk+unsubscr...@googlegroups.com. >> To post to this group, send email to rubyonrails-talk@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/rubyonrails-talk/CAL%3D0gLtXdKNdw%3De8b-Uozdp%2B0f1aruY6Ou21zBhtipL5bnOksA%40mail.gmail.com. >> For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Talk" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-talk+unsubscr...@googlegroups.com. > To post to this group, send email to rubyonrails-talk@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/rubyonrails-talk/CAHUC_t--QO3H8P51y3BFKECefXdQSaA2dnYX9KXdpRSvtfzAFQ%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-talk+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-talk@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/CAL%3D0gLtCC354bW9wCNMUSxZdEK63wGCTnBPMrzeVMWR18nsBXA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.