I have cloned it and running benchmarks on it. Might not be able to complete it tonight. -W
On 28 February 2012 19:55, Edson Tirelli <[email protected]> wrote: > > I am sure he would not deny that... :) you are helping to make the > world a better place... :) > > In any case, please open a JIRA so that this does not get lost in the > e-mails. It is a low hanging fruit, very isolated and simple to fix. So > anyone looking for a starting work to contribute to the project can do it. > Otherwise I will do it when I get the time. > > Thanks, > Edson > > On Tue, Feb 28, 2012 at 1:45 PM, SirMungus <[email protected]> wrote: > >> >> Edson Tirelli-4 wrote >> > >> > I see what you are saying and I think it works. Although, it will be >> > heavier, it would cover scenarios not covered by the current >> > implementation. >> > >> > My suggestion is if you can, please create a test case for the >> problem, >> > change the collectSet accumulate function to do what you propose and >> send >> > a >> > pull request. I will review it and apply. I think in this case, making >> > user's life easier by not requiring immutability might trump >> performance, >> > but we need to evaluate some tests just in case. >> > >> Edson, thanks for the offer. I'll see what I can do. Since I work at a >> financial services company, I practically have to get Obama's permission >> to >> do anything official on an open source project. :) >> >> -- >> View this message in context: >> http://drools.46999.n3.nabble.com/BUG-5-3-0-Final-CollectSetAccumulateFunction-should-probably-use-IdentityHashMap-internally-tp3774079p3784963.html >> Sent from the Drools: Developer (committer) mailing list mailing list >> archive at Nabble.com. >> _______________________________________________ >> rules-dev mailing list >> [email protected] >> https://lists.jboss.org/mailman/listinfo/rules-dev >> > > > > -- > Edson Tirelli > JBoss Drools Core Development > JBoss by Red Hat @ www.jboss.com > > _______________________________________________ > rules-dev mailing list > [email protected] > https://lists.jboss.org/mailman/listinfo/rules-dev > >
_______________________________________________ rules-dev mailing list [email protected] https://lists.jboss.org/mailman/listinfo/rules-dev
