Thank you for your help.
I manage to make it works. Now I know how to do it. I miss the fork in
my first attempt that why it can't work.
Philippe
Le 26/11/2013 22:43, John Clements a écrit :
On Nov 26, 2013, at 10:15 AM, Philippe Delrieu wrote:
I try to commit my change on json.rs but I didn't manage to make it work.
I'am not very use to git. I've done :
git clone https://github.com/mozilla/rust.git
git rebase master
git push --> error 403. I use my github account
Sorry for to ask for get but can anybody tell me what to do to send my change.
For Rust (and most other projects of this size), you can't just push to the master thread. What you
need to do instead is to issue a "Pull Request". This says, in effect: "Hey Rust
developers: here's a patch! Would you put it into the tree?"
In order to do this, you'll want to go to github, fork the rust project, make changes to
your own repo, push the changes back to your own repo, then click the "Pull
Request" button to request integration of your changes into mozilla's repo.
That was a super-high-level overview, sorry for being so brief.
John Clements
Philippe Delrieu
Le 22/11/2013 19:22, Philippe Delrieu a écrit :
I've done the modification in json.rs (add comment with sample code in md
format and test code).
I've do the commit and git pull.
The test compile but I didn't manage to run it.
I use the command: make -j 20 check TESTNAME=src/libextra/json.rs
There are errors before and when I force the assert to false I have no error
for json.
Tell me if it's ok.
Philippe
Le 22/11/2013 10:07, Corey Richardson a écrit :
On Fri, Nov 22, 2013 at 3:33 AM, Philippe Delrieu
<[email protected]> wrote:
I finished my test with the rust json API. I made a non trivial example code
that summaries what I understand. I put it at the end of the mail. Could
someone (the developer of the API for example) add it to the comment of the
json API. I don't think I have the right. It can be good to add it as a test
case to validate that it stay up to date.
Put any remarks about the code if I've made some mistake or if there is
better code.
Send a pull request adding it.
_______________________________________________
Rust-dev mailing list
[email protected]
https://mail.mozilla.org/listinfo/rust-dev
_______________________________________________
Rust-dev mailing list
[email protected]
https://mail.mozilla.org/listinfo/rust-dev
_______________________________________________
Rust-dev mailing list
[email protected]
https://mail.mozilla.org/listinfo/rust-dev
