On Wed, 7 Mar 2012 12:30:29 +0700 Simon Horman <[email protected]> wrote:
> On Wed, Mar 07, 2012 at 11:08:52AM +0900, Isaku Yamahata wrote: >> On Tue, Mar 06, 2012 at 08:42:16AM +0900, FUJITA Tomonori wrote: >> > On Mon, 5 Mar 2012 09:34:06 +0700 >> > Simon Horman <[email protected]> wrote: >> > >> > > OFPAction.parser() should call the parser of one of the classes >> > > registered >> > > in _ACTION_TYPES() rather than calling itself until a buffer underflow >> > > occurs. >> > > >> > > Also, it is not necessary to increment offset as the parser method of the >> > > registered classes re-parse the type and length and thus do not expect it >> > > to be incremented. >> > > >> > > Signed-off-by: Simon Horman <[email protected]> >> > > >> > > --- >> > > >> > > I am unsure of the merit of using assert on error in this code. >> > Yeah, a malicious switch can cause this assertion. It's pointless. We >> > should handle about this error properly. At lease, please put a >> > "FIXME" comment. Assertion is only useful to find our bugs not >> > other components' bugs (switches, etc). >> >> I have to admit some assert I put are pointless. Needs clean up. >> OFPParserError (or something like that) needs to be introduced instead of >> assert. >> >> As for malicious packet, the exception is raised up to gevent StreamServer. >> And then the connection is disconnected. This is intentional. >> (It should be explicitly commented in the code. Okay I'll send a patch) >> >> If we'd like to be a bit more smarter like skip to the next message, >> it can be easily done by catching exception explicitly. > > Personally I think it would be nice to catch the exception. > The following patch is an attempt to do that. But perhaps > the behaviour of closing the connection is better than > simply ignoring the packet as this patch does. Ok, I applied the previous simple one. Let's rethink about this issue later. Thanks, ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
