On Thu, 17 May 2012 11:43:39 +0900 Isaku Yamahata <[email protected]> wrote:
> On Thu, May 17, 2012 at 07:38:32AM +0900, FUJITA Tomonori wrote: >> > + @staticmethod >> > + def lldp_parse(data): >> > + eth = Ethernet(data) >> > + if not (eth.dst == lldp.LLDP_MAC_NEAREST_BRIDGE and >> > + eth.type == lldp.ETH_TYPE_LLDP): >> > + raise LLDPPacket.LLDPUnknownFormat( >> > + msg='unknown dst mac(%s) or type(%s)' % (eth.dst, >> > eth.type)) >> >> NOX's discovery code uses register_for_packet_match() to register a >> handler to handle incoming lldp packets. The handler receives only >> lldp packets. >> >> However, our discovery packet_in_handler receives all the packets >> (note that other applications are likely to install rules for >> packet_in). So the packet_in_handler should ignore non lldp packets >> instead of logging error messages. > > I'll quieten it with the next spin. btw, please don't create something like register_for_packet_match(). For now, just handle such in discovery code. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
