On Mon, 21 May 2012 23:41:43 +0900 Isaku Yamahata <[email protected]> wrote:
>> I'm not sure we are on the same page. I'm talking about the breakage >> of ofp_msg_to_ev(). > > Ahh, I see. So I should have talked about _set_msg_type() > It should have been > > @_register_parser > @_set_msg_type(ofproto_v1_0.OFPT_VENDOR) > class OFPVendor(MsgBase): > ... > > # no decorator > class NiciraHeader(OFPVendor): > ... > > @_set_msg_type(ofproto_v1_0.OFPT_VENDOR) > class NXRoleRequest(MsgBase): > ... > > Then, EventOFPVendor and EventNxRoleRequest are created. > The point is that _OFP_MSG_EVENTS is keyed by class name, not by > OF type number. Yeah, that's what I'm not convinced about, generating EventNX*. It's an OFPVendor message so I think that we shoud use with EventOFPVendor. >> > Does the above satisfy your requirement? Or can you elaborate on what >> > you need? >> >> As I always say, I want less code in the code for stopgap vendor stuff. > > I see. If only nx role parser is needed, the above I'm proposing might be > overkill. I think that there are some other switch-to-controller NX messages (we haven't implemented yet) but they are still minor. You proposal code is cleaner but I'm not convinced that handling NX* in the same way as OFP messages (as the first class citizen) is the right thing to do. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
