On Wed, Jun 20, 2012 at 11:59:22AM +0900, FUJITA Tomonori wrote: > On Wed, 20 Jun 2012 11:28:03 +0900 (JST) > FUJITA Tomonori <[email protected]> wrote: > > > On Wed, 20 Jun 2012 09:21:32 +0900 > > Simon Horman <[email protected]> wrote: > > > >> On Wed, Jun 20, 2012 at 07:54:10AM +0900, FUJITA Tomonori wrote: > >>> I'm not sure where is the best place for this. Any suggestion? > >> > >> I have no strong feelings on this, but this location does seem > >> better than ryu/ofproto/nx_match.py, where a limited number > >> of these constants currently exist. > >> > >> Personally I would rather just add constants to ip.py as they are needed, > >> but I don't feel strongly about that either. > >> > >> I have verified that the constants you have are correct. > >> I used the Linux kernel as a reference. > > > > I just copied them from Linux kernel. I don't have no preference. How > > about adding only IPPROTO_ constants that OVS uses now? Ryu is likely > > to use them. > > > > - > >>From 6e12052f5721e27d210f11ee479515da890421e4 Mon Sep 17 00:00:00 2001 > > From: FUJITA Tomonori <[email protected]> > > Date: Wed, 20 Jun 2012 11:21:09 +0900 > > Subject: [PATCH] add IPPROTO_ constants > > > > NXM and OXM code need IPPROTO_ constants. They can be shared safely > > (will not be changed). So better to share them in a common file. > > > > This adds only IPPROTO_ constants that OVS uses now, which we are > > likely to use. > > > > Signed-off-by: FUJITA Tomonori <[email protected]> > > --- > > ryu/ofproto/in.py | 27 +++++++++++++++++++++++++++ > > 1 files changed, 27 insertions(+), 0 deletions(-) > > create mode 100644 ryu/ofproto/in.py > > Oops, I've already merged this mistakenly.
No problem, lets leave it as is :) ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
