On Wed, Jan 29, 2014 at 01:45:58PM +0900, FUJITA Tomonori wrote: > On Wed, 29 Jan 2014 12:05:55 +0900 > Simon Horman <[email protected]> wrote: > > > Signed-off-by: Simon Horman <[email protected]> > > --- > > ryu/ofproto/ofproto_v1_4_parser.py | 123 > > +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 123 insertions(+) > > > > diff --git a/ryu/ofproto/ofproto_v1_4_parser.py > > b/ryu/ofproto/ofproto_v1_4_parser.py > > index 0c790c9..8b4ee60 100644 > > --- a/ryu/ofproto/ofproto_v1_4_parser.py > > +++ b/ryu/ofproto/ofproto_v1_4_parser.py > > @@ -2322,3 +2322,126 @@ class OFPActionSetQueue(OFPAction): > > def serialize(self, buf, offset): > > msg_pack_into(ofproto.OFP_ACTION_SET_QUEUE_PACK_STR, buf, > > offset, self.type, self.len, self.queue_id) > > + > > + > > [email protected]_action_type(ofproto.OFPAT_SET_FIELD, > > + ofproto.OFP_ACTION_SET_FIELD_SIZE) > > +class OFPActionSetField(OFPAction): > > + """ > > + Set field action > > + > > + This action modifies a header field in the packet. > > + > > + ================ ====================================================== > > + Attribute Description > > + ================ ====================================================== > > + field Instance of ``OFPMatchField`` > > + ================ ====================================================== > > + """ > > + def __init__(self, field=None, **kwargs): > > + # old api > > + # OFPActionSetField(field) > > + # new api > > + # OFPActionSetField(eth_src="00:00:00:00:00") > > + super(OFPActionSetField, self).__init__() > > + if isinstance(field, OFPMatchField): > > + # old api compat > > + assert len(kwargs) == 0 > > + self.field = field > > Let's drop the OF1.2/1.3 old API for OF1.4. For your convenience (I > guess that you don't like to shuffle the patches), I merged this but > I'll send a patch to remove the old API for OF1.4.
Thanks, that does simplify things rather a lot for me. I can handle removing this if you don't already have a patch handy. ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
