Ok. I tried to find any of-config pyang module specification in public access, but found nothing, except one in of-config pdf spec. I think that proposed patch change code in a quite compatible way (i.e. save _ELEMENTS attribute) and add useful functionality (i.e. port tunnel support).
> hi, > > > Add port tunnels support according to OFConfig specification. > > > > Signed-off-by: Raman Budny <raman_bu...@epam.com> > > --- > > Port tunnel support in of_config library seems to be supported > > in not full manner. There are four kind of port tunnels listed in > > OFConfig specification (v1.1.1, p. 47): > > - OFPortBaseTunnelType, > > - OFPortIPGRETunnelType, > > - OFPortVXLANTunnelType, > > - OFPortNVGRETunnelType, > > but currently there is no way to get/modify parameters of these tunnels in > > of_config library. This patch should add required classes and link them > > to OFPortType. > > > > Unfortunately, > > 1) last three classes should inherit elements from > > OFPortBaseTunnelType, but I haven't found simple way to implement it > > without deep code rewriting (because of _ELEMENTS is class variable). > > > > 2) I haven't found suitable way to represent the relation of > > mutual exclusion between different tunnel type objects > > (i. e. port object should refer to only one tunnel object of > > specific type). > > > > I will be glad to receive your advices, how to implement these features, > > and ready to improve this patch according to them. > > thank you for working on this. > as commented, this module is intended to be replaced with a generated > code in future. so please try to keep it compatible with the code > which would be generated by tools/pyang_plugins/ryu. > ie. readablity and code duplications are not primary concerns here. > > YAMAMOTO Takashi ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ Ryu-devel mailing list Ryu-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ryu-devel
