On Tue, 16 Jun 2015 08:53:27 +0300
Eran Gampel <[email protected]> wrote:
> Please see attached patch
Thanks, I got some errors. Can you respin the patch?
fujita@ubuntu:~/git/ryu$ ./run_tests.sh
(snip)
======================================================================
ERROR: test_4_60_ofp_flow_mod_packet
(ryu.tests.unit.ofproto.test_parser.Test_Parser)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/fujita/git/ryu/ryu/tests/unit/ofproto/test_parser.py",
line 255, in _run
self._test_msg(name, wire_msg, json_str)
File "/home/fujita/git/ryu/ryu/tests/unit/ofproto/test_parser.py",
line 195, in _test_msg
msg2 = self._jsondict_to_msg(dp, json_dict)
File "/home/fujita/git/ryu/ryu/tests/unit/ofproto/test_parser.py",
line 173, in _jsondict_to_msg
return ofproto_parser.ofp_msg_from_jsondict(dp, jsondict)
File "/home/fujita/git/ryu/ryu/ofproto/ofproto_parser.py", line 109,
in ofp_msg_from_jsondict
return cls.from_jsondict(v, datapath=dp)
File "/home/fujita/git/ryu/ryu/lib/stringify.py", line 326, in
from_jsondict
kwargs = cls._restore_args(_mapdict_kv(decode, dict_))
File "/home/fujita/git/ryu/ryu/lib/stringify.py", line 52, in
<lambda>
_mapdict_kv = lambda f, d: dict([(k, f(k, v)) for k, v in
d.items()])
File "/home/fujita/git/ryu/ryu/lib/stringify.py", line 325, in
<lambda>
**additional_args)
File "/home/fujita/git/ryu/ryu/lib/stringify.py", line 266, in
_decode_value
return cls._get_decoder(k, decode_string)(json_value)
File "/home/fujita/git/ryu/ryu/lib/stringify.py", line 277, in
_decode
v = cls.obj_from_jsondict(json_value, **additional_args)
File "/home/fujita/git/ryu/ryu/lib/stringify.py", line 254, in
obj_from_jsondict
return obj_cls.from_jsondict(v, **additional_args)
File "/home/fujita/git/ryu/ryu/ofproto/ofproto_v1_3_parser.py", line
892, in from_jsondict
o.serialize(buf, 0)
File "/home/fujita/git/ryu/ryu/ofproto/ofproto_v1_3_parser.py", line
988, in serialize
in self._fields2]
File "/home/fujita/git/ryu/ryu/ofproto/oxm_fields.py", line 208, in
_from_user
value = t.from_user(value)
File "/home/fujita/git/ryu/ryu/lib/type_desc.py", line 40, in
from_user
bin = chr(i & 255) + bin
TypeError: unsupported operand type(s) for &: 'unicode' and 'int'
-------------------- >> begin captured stdout << ---------------------
processing test_4_60_ofp_flow_mod_packet ...
--------------------- >> end captured stdout << ----------------------
----------------------------------------------------------------------
Ran 24756 tests in 27.469s
FAILED (errors=1)
Running pep8 ...
ryu/ofproto/nx_match.py:921:1: E302 expected 2 blank lines, found 1
@_register_make
^
ryu/ofproto/nx_match.py:923:21: E127 continuation line over-indented
for visual indent
ofproto_v1_0.NXM_NX_PKT_MARK_W])
^
ryu/ofproto/nx_match.py:931:17: E128 continuation line under-indented
for visual indent
rule.wc.pkt_mark_mask)
^
------------------------------------------------------------------------------
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
