Currently, the unit tests for lib/ofctl_v1_* include tests for only conversion actions and match, but does not include tests for sending messages functions.
The following patches implement the unit tests for sending messages functions by using the json representations of test_parser.py and includes some improvements. IWASE Yusuke (11): ofproto_v1_[2345]_parser: Set default length field packet_data_generator: Add ofp_group_stats messages for OF1.2 packet_data: Regen test_parser: Add some expected json representations ofproto_v1_[23]_parser: Add default arguments in OFPQueueProp lib/ofctl: Confirm UTF-8 in binary fields lib/ofctl: Rename unit test for action/match lib/ofctl: Implement unit test for sending messages lib/ofctl: Add test cases for ofctl_v1_3 lib/ofctl: Add test cases for ofctl_v1_2 lib/ofctl: Add test cases for ofctl_v1_0 ryu/lib/ofctl_v1_0.py | 4 +- ryu/lib/ofctl_v1_2.py | 4 +- ryu/lib/ofctl_v1_3.py | 4 +- ryu/ofproto/ofproto_v1_2_parser.py | 4 +- ryu/ofproto/ofproto_v1_3_parser.py | 24 +- ryu/ofproto/ofproto_v1_4_parser.py | 2 +- ryu/ofproto/ofproto_v1_5_parser.py | 4 +- .../of12/3-61-ofp_group_stats_request.packet | Bin 0 -> 24 bytes .../of12/3-62-ofp_group_stats_reply.packet | Bin 0 -> 64 bytes ryu/tests/packet_data_generator/src/x3.erl | 12 +- .../ofctl_json/of10/1-2-ofp_flow_mod.packet.json | 23 + .../of12/3-0-ofp_desc_stats_reply.packet.json | 9 + .../of12/3-11-ofp_flow_stats_request.packet.json | 11 + .../of12/3-12-ofp_flow_stats_reply.packet.json | 75 + .../of12/3-16-ofp_experimenter.packet.json | 8 + .../ofctl_json/of12/3-2-ofp_flow_mod.packet.json | 41 + .../ofctl_json/of12/3-21-ofp_group_mod.packet.json | 22 + .../ofctl_json/of12/3-22-ofp_port_mod.packet.json | 9 + .../3-25-ofp_aggregate_stats_request.packet.json | 11 + .../3-26-ofp_aggregate_stats_reply.packet.json | 9 + .../of12/3-28-ofp_table_stats_reply.packet.json | 32134 +++++++++++++++++++ .../of12/3-30-ofp_port_stats_reply.packet.json | 34 + ...3-32-ofp_group_features_stats_reply.packet.json | 104 + .../3-34-ofp_group_desc_stats_reply.packet.json | 20 + .../3-35-ofp_queue_get_config_request.packet.json | 3 + .../3-36-ofp_queue_get_config_reply.packet.json | 43 + .../of12/3-38-ofp_queue_stats_reply.packet.json | 25 + .../of12/3-6-ofp_features_reply.packet.json | 30 + .../of12/3-62-ofp_group_stats_reply.packet.json | 17 + .../ofctl_json/of13/4-0-ofp_desc_reply.packet.json | 9 + .../of13/4-11-ofp_flow_stats_request.packet.json | 11 + .../of13/4-12-ofp_flow_stats_reply.packet.json | 102 + .../of13/4-16-ofp_experimenter.packet.json | 8 + .../ofctl_json/of13/4-2-ofp_flow_mod.packet.json | 91 + .../ofctl_json/of13/4-21-ofp_group_mod.packet.json | 21 + .../ofctl_json/of13/4-22-ofp_port_mod.packet.json | 9 + .../4-25-ofp_aggregate_stats_request.packet.json | 11 + .../4-26-ofp_aggregate_stats_reply.packet.json | 9 + .../of13/4-28-ofp_table_stats_reply.packet.json | 16 + .../of13/4-30-ofp_port_stats_reply.packet.json | 38 + .../of13/4-32-ofp_group_features_reply.packet.json | 104 + .../of13/4-34-ofp_group_desc_reply.packet.json | 20 + .../4-35-ofp_queue_get_config_request.packet.json | 3 + .../4-36-ofp_queue_get_config_reply.packet.json | 83 + .../of13/4-38-ofp_queue_stats_reply.packet.json | 31 + .../ofctl_json/of13/4-45-ofp_meter_mod.packet.json | 31 + .../of13/4-48-ofp_meter_config_reply.packet.json | 19 + .../of13/4-50-ofp_meter_stats_reply.packet.json | 19 + .../of13/4-52-ofp_meter_features_reply.packet.json | 19 + .../of13/4-54-ofp_port_desc_reply.packet.json | 30 + .../of13/4-56-ofp_table_features_reply.packet.json | 11928 +++++++ .../of13/4-58-ofp_group_stats_reply.packet.json | 19 + ryu/tests/unit/lib/test_ofctl.py | 1143 +- ryu/tests/unit/lib/test_ofctl_action_match.py | 868 + .../of12/3-61-ofp_group_stats_request.packet.json | 6 + .../of12/3-62-ofp_group_stats_reply.packet.json | 25 + ...ib-ofctl-ofp_table_features_request.packet.json | 7 + 57 files changed, 46511 insertions(+), 855 deletions(-) create mode 100644 ryu/tests/packet_data/of12/3-61-ofp_group_stats_request.packet create mode 100644 ryu/tests/packet_data/of12/3-62-ofp_group_stats_reply.packet create mode 100644 ryu/tests/unit/lib/ofctl_json/of10/1-2-ofp_flow_mod.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-0-ofp_desc_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-11-ofp_flow_stats_request.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-12-ofp_flow_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-16-ofp_experimenter.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-2-ofp_flow_mod.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-21-ofp_group_mod.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-22-ofp_port_mod.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-25-ofp_aggregate_stats_request.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-26-ofp_aggregate_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-28-ofp_table_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-30-ofp_port_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-32-ofp_group_features_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-34-ofp_group_desc_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-35-ofp_queue_get_config_request.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-36-ofp_queue_get_config_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-38-ofp_queue_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-6-ofp_features_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of12/3-62-ofp_group_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-0-ofp_desc_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-11-ofp_flow_stats_request.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-12-ofp_flow_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-16-ofp_experimenter.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-2-ofp_flow_mod.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-21-ofp_group_mod.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-22-ofp_port_mod.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-25-ofp_aggregate_stats_request.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-26-ofp_aggregate_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-28-ofp_table_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-30-ofp_port_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-32-ofp_group_features_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-34-ofp_group_desc_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-35-ofp_queue_get_config_request.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-36-ofp_queue_get_config_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-38-ofp_queue_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-45-ofp_meter_mod.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-48-ofp_meter_config_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-50-ofp_meter_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-52-ofp_meter_features_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-54-ofp_port_desc_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-56-ofp_table_features_reply.packet.json create mode 100644 ryu/tests/unit/lib/ofctl_json/of13/4-58-ofp_group_stats_reply.packet.json create mode 100644 ryu/tests/unit/lib/test_ofctl_action_match.py create mode 100644 ryu/tests/unit/ofproto/json/of12/3-61-ofp_group_stats_request.packet.json create mode 100644 ryu/tests/unit/ofproto/json/of12/3-62-ofp_group_stats_reply.packet.json create mode 100644 ryu/tests/unit/ofproto/json/of13/lib-ofctl-ofp_table_features_request.packet.json -- 1.9.1 ------------------------------------------------------------------------------ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
