On Fri, 1 Jul 2016 12:55:33 +0900 Takashi YAMAMOTO <yamam...@ovn.org> wrote:
> On Tue, Jun 28, 2016 at 5:03 PM, IWAMOTO Toshihiro <iwam...@valinux.co.jp> > wrote: > >> At Tue, 28 Jun 2016 16:19:52 +0900, >> Takashi YAMAMOTO wrote: >> > >> > [1 <text/plain; UTF-8 (7bit)>] >> > On Tue, Jun 28, 2016 at 3:16 PM, IWAMOTO Toshihiro < >> iwam...@valinux.co.jp> >> > wrote: >> > >> > > At Tue, 28 Jun 2016 15:02:52 +0900, >> > > Takashi YAMAMOTO wrote: >> > > > >> > > > On Tue, Jun 28, 2016 at 2:25 PM, IWAMOTO Toshihiro < >> > > iwam...@valinux.co.jp> >> > > > wrote: >> > > > >> > > > > If an AppManager.close call is started and all AppManager.services >> > > > > are stop, AppManager.run_apps starts another close() call, >> > > > > >> > > > >> > > > why joinall in run_apps returns before AppManager.close finish >> clearing >> > > > self.applications? >> > > >> > > Because OfctlService isn't in services (run_apps local variable) and >> > > RyuApp.close() causes eventlet context switches? >> > > >> > >> > why it isn't in "services"? >> > i thought instantiate_apps returned auto-loaded apps as well. >> > if not, isn't it better to fix it instead? >> >> Look for "t is not None" in that function. >> I thought this is intentional for some reason, and changing this would >> make existing applicitions unstoppable. >> > > hm. i don't remember either, but maybe just because the event loop thread > is joined by app.stop()? > i think it's safe to make run_apps wait for them as well. Can you please send a patch? Let's see if someone would complain about the breakage with such approach until the next release. ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Ryu-devel mailing list Ryu-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ryu-devel
