Hi Tungyueh, Thank you for updating your patch!
It looks good to me and the API reference can be successfully built on my environment. Thanks, Iwase On 2016年09月02日 12:49, 林東岳 wrote: > Hi, > > I write the reference for this API. > > tungyueh > > Iwase Yusuke <[email protected]> 於 2016年9月2日 週五 上午9:38寫道： > >> Hi Tungyueh, >> >> (If possible) In addition to this patch, >> could you write the reference for this API you implemented into the >> following? >> It might be helpful for Ryu users using this API, I guess. >> https://github.com/osrg/ryu/blob/master/doc/source/app/ofctl_rest.rst >> >> Thanks, >> Iwase >> >> >> On 2016年09月02日 10:24, Iwase Yusuke wrote: >>> Hi Fujita-San, >>> >>> On 2016年09月01日 21:29, FUJITA Tomonori wrote: >>>> On Thu, 01 Sep 2016 08:50:06 +0000 >>>> 林東岳 <[email protected]> wrote: >>>> >>>>> From 1633af89f6dd5f2b2e42023c62b744362d553546 Mon Sep 17 00:00:00 2001 >>>>> From: tungyueh <[email protected]> >>>>> Date: Thu, 25 Aug 2016 15:53:17 +0800 >>>>> Subject: [PATCH] add change role API in ofctl_rest >>>>> >>>>> let default role to be equal >>>>> >>>>> Signed-off-by: tungyueh <[email protected]> >>>>> --- >>>>> ryu/app/ofctl_rest.py | 12 ++++++++++++ >>>>> ryu/lib/ofctl_utils.py | 3 +++ >>>>> ryu/lib/ofctl_v1_2.py | 6 ++++++ >>>>> ryu/lib/ofctl_v1_3.py | 6 ++++++ >>>>> ryu/lib/ofctl_v1_4.py | 6 ++++++ >>>>> ryu/lib/ofctl_v1_5.py | 5 +++++ >>>>> 6 files changed, 38 insertions(+) >>>> >>>> Thanks! >>>> >>>> Iwase, looks good to you? >>> >>> Yes, it looks good to me. >>> It works well on my environment. >>> >>> LOG: >>> $ curl -X POST -d '{ >>>> "dpid": 1, >>>> "role": "EQUAL" >>>> }' http://localhost:8080/stats/role >>> $ curl -X POST -d '{ >>>> "dpid": 1, >>>> "role": "MASTER" >>>> }' http://localhost:8080/stats/role >>> >>> $ ryu-manager ryu.app.ofctl_rest >>> ...(snip) >>> (10614) wsgi starting up on http://0.0.0.0:8080 >>> (10614) accepted ('127.0.0.1', 43642) >>> 127.0.0.1 - - [02/Sep/2016 10:16:00] "POST /stats/role HTTP/1.1" 200 115 >> 0.017469 >>> (10614) accepted ('127.0.0.1', 43644) >>> 127.0.0.1 - - [02/Sep/2016 10:16:53] "POST /stats/role HTTP/1.1" 200 115 >> 0.000837 >>> ...(snip) >>> >>> And, Wireshark shows ofctl_rest can send the role request correctly. >>> >>> >>> Thank you for submitting your patch and quick response, Tungyueh! >>> >>> >>> Thanks, >>> Iwase >> > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel > ------------------------------------------------------------------------------ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
