Hi,

Thank you for your reporting!


On 2017年02月17日 08:51, surlyjake wrote:
> http://ryu.readthedocs.io/en/latest/nicira_ext_ref.html?highlight=frag 
> indicates that ryu can make an 'ip_frag' match, but doesnt define the mapping 
> between integers and the five options (from 
> http://manpages.ubuntu.com/manpages/precise/man8/ovs-ofctl.8.html):
>     no Matches only non-fragmented packets.
>     yes Matches all fragments.
>     first Matches only fragments with offset 0.
>     later Matches only fragments with nonzero offset.
>     not_later Matches non-fragmented packets and fragments with zero offset.
> 
> When i test, setting an ip_frag match to
>     0x00=no
>     0x01=first
>     0x02=<error>
>     0x03=later
>     should there be enums in nicira_ext.py to define these values?
> 
> if so, i can submit a patch, but also need to know correct values for the 
> other two match rules('yes' and 'not_later').

Great! Yes, please!

The value and mask for "ip_frag" match field seems to be defined at the 
following.
  
https://github.com/openvswitch/ovs/blob/master/include/openvswitch/flow.h#L49-L52
  https://github.com/openvswitch/ovs/blob/master/lib/meta-flow.c#L2199-L2211

According to the above, I guess the constants should be like:

FLOW_NW_FRAG_ANY = 1 << 0    // Set for any IP frag.
FLOW_NW_FRAG_LATER = 1 << 1  // Set for IP frag with nonzero offset.
FLOW_NW_FRAG_MASK = FLOW_NW_FRAG_ANY | FLOW_NW_FRAG_LATER

// legend: (value, mask)
NXM_IP_FRAG_NO = (0, FLOW_NW_FRAG_MASK))
NXM_IP_FRAG_FIRST = (FLOW_NW_FRAG_ANY, FLOW_NW_FRAG_MASK)
NXM_IP_FRAG_LATER = (FLOW_NW_FRAG_MASK, FLOW_NW_FRAG_MASK)
...(snip)


Thanks,
Iwase


> 
> 
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> 
> 
> 
> _______________________________________________
> Ryu-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ryu-devel
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to