Hi, Fujita-san Sure, I'll update my patch.
On 2017年11月05日 20:55, FUJITA Tomonori wrote:
On Tue, 31 Oct 2017 13:47:02 +0900 Satoshi Fujimoto <satoshi.fujimo...@gmail.com> wrote:As a default, netaddr.valid_ipv4() uses the "aton" rule for its validation, so valid_ipv4('2') and valid_ipv4('1.2.3') returns True. It may cause unexpected behaviors. This commit replaces netaddr.valid_ipv4() to ryu.lib.ip.valid_ipv4(), which is wrapper of netaddr.valid_ipv4(), and use "pton" rule in the method. So, address representation like '2' or '1.2.3' will be rejected. Signed-off-by: Satoshi Fujimoto <satoshi.fujimo...@gmail.com> --- ryu/controller/controller.py | 5 +-- ryu/controller/ofp_api.py | 3 +- ryu/lib/hub.py | 7 ++-- ryu/lib/mrtlib.py | 14 +++----- ryu/lib/packet/bgp.py | 6 ++-- ryu/lib/packet/zebra.py | 39 ++++++++++------------ ryu/services/protocols/bgp/base.py | 3 +- ryu/services/protocols/bgp/bgpspeaker.py | 9 ++--- ryu/services/protocols/bgp/core.py | 3 +- .../protocols/bgp/core_managers/table_manager.py | 9 ++--- ryu/services/protocols/bgp/rtconf/common.py | 5 ++- ryu/services/protocols/bgp/rtconf/neighbors.py | 4 ++- ryu/services/protocols/bgp/utils/bgp.py | 2 +- ryu/services/protocols/bgp/utils/validation.py | 6 ++-- ryu/services/protocols/ovsdb/manager.py | 8 ++--- ryu/services/protocols/zebra/client/zclient.py | 9 ++--- ryu/services/protocols/zebra/db/route.py | 6 ++-- ryu/services/protocols/zebra/server/zserver.py | 7 ++-- 18 files changed, 69 insertions(+), 76 deletions(-)I can't apply this cleanly. Can you update this for the latest master?
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Ryu-devel mailing list Ryu-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ryu-devel
