Hi Iwase, No problem! In attach you can find the patch file with short comment! I ran the test quickly and everything seems fine!
Thanks for the information and if you have any question or troubles with my patch, don't hesitate to contact me! Kind regards, Jerico ________________________________ Van: Iwase Yusuke <iwase.yusu...@gmail.com> Verzonden: zaterdag 25 november 2017 7:50 Aan: jeric...@hotmail.com CC: ryu-devel@lists.sourceforge.net Onderwerp: Re: [Ryu-devel] simple_switch_13.py Hi Jerico, Sorry for the delay. Great! Thank you for your contribution! We use "git format-patch" style patch on this mailing list and your patch looks good to me. https://github.com/osrg/ryu/blob/master/CONTRIBUTING.rst If you don't mind, could you add your name and some comments about "why this modification is needed". For adding your name and e-mail address, just add "-s" option to "git format-patch" command. Please refer to the following my patch for an example; https://www.mail-archive.com/ryu-devel@lists.sourceforge.net/msg14212.html Thanks, Iwase On 2017年11月24日 17:35, Jerico Moeyersons wrote: > Hi Iwase, > > In attach you find the patch file (from my forked github repo). Is this > anything you need or do I need to do something in the original repository? > > Thanks in advance! > > Kind regards, > > Jerico > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > *Van:* Jerico Moeyersons <jeric...@hotmail.com> > *Verzonden:* vrijdag 24 november 2017 9:16 > *Aan:* Iwase Yusuke; ryu-devel@lists.sourceforge.net > *Onderwerp:* Re: [Ryu-devel] simple_switch_13.py > > Hi Iwase, > > Sure, I just send you the files through here or? > > Thanks! > > Kind regards, > > Jerico > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > *Van:* Iwase Yusuke <iwase.yusu...@gmail.com> > *Verzonden:* vrijdag 24 november 2017 9:01 > *Aan:* jeric...@hotmail.com > *CC:* ryu-devel@lists.sourceforge.net > *Onderwerp:* Re: [Ryu-devel] simple_switch_13.py > > Hi Jerico, > > Thanks! You are right! > I could reproduce this issue. > > Let's add "eth_src=src". > Could you send a patch for this issue? > > Thanks, > Iwase > > > On 2017年11月24日 16:37, Jerico Moeyersons wrote: >> Hi Iwase, >> >> Thanks for your response! In attach I've added a figure of my setup and with >> that I will try to >> explain the problem: >> >> So, I have two switches, each connected (with a normal port = controller >> port) to the Ryu >> Controller. These switches are interconnected with each other with an >> OF-port. On switch one, there >> are two host, on the second switch only one. >> >> My test case: >> - From Host 3, ping to Host 1 (ping 192.168.0.10) --> No problems, flows are >> added and after some >> time, the learning switch don't receive any package in any more (because of >> the flows) >> - From Host 3, ping to Host 2 (ping 192.168.0.20) --> Here the problem >> starts: because of the ping >> to an unknown host, you will flood. The package will go to the first switch, >> flood, ... But when >> Host 2 responds and the package arrives at the second switch (till here >> everything is working >> normal), this flow won't be added, because the destination (Host 3) is >> already known as a flow. The >> consequence: the source (Host 2) is never added to a flow on the second >> switch, and thus the >> controller will always flood a message on the second switch. >> >> Hope you can reproduce the problem now (FYI: I'm using OF 1.3)! If not, I >> will redo my test and >> provide you with some screenshots. >> >> Thanks in advance! >> >> Kind regards, >> >> Jerico Moeyersons >> ---------------------------------------------------------------------------------------------------- >> *Van:* Iwase Yusuke <iwase.yusu...@gmail.com> >> *Verzonden:* vrijdag 24 november 2017 8:04 >> *Aan:* jeric...@hotmail.com >> *CC:* ryu-devel@lists.sourceforge.net >> *Onderwerp:* Re: [Ryu-devel] simple_switch_13.py >> Hi Jerico, >> >> Thank you for your report! >> >> Adding "eth_src=src" in the match looks good to me, but please confirm your >> situation. >> >> You mean this issue will occur, when we do the following? >> - Connect to the first switch and learn the connected hosts >> - Connect to the second switch and try to learn the new hosts >> ---> the second switch cannot learn the connected hosts which the first >> switch already know >> >> I asked this question because I couldn't reproduce your situation on my >> environment (Mininet). >> >> Thanks, >> Iwase >> >> >> On 2017年11月24日 00:19, Jerico Moeyersons wrote: >>> Hello everyone, >>> >>> I'm kinda new to bug reporting, so I found this e-mail address. If I need >>> to do it elsewhere, please >>> notify me of that! >>> >>> The reason why I mail you is because I found a 'bug' (or maybe it is the >>> purpose of the example) in >>> the example switch. Here, a flow is added with as match the destination and >>> the in_port. But when >>> you combine two switches (I use the small Zodiac FX switch), this will have >>> the issue that when you >>> want to add a second flow to something on the second switch, no new flow is >>> added (because the >>> destination is know, ...). >>> >>> So my suggestion: add the eth_src=src in the match entry before adding the >>> flow (this solved the >>> issue for me). >>> >>> Can you please provide feedback? >>> >>> Thanks in advance! >>> >>> Kind regards, >>> >>> Jerico Moeyersons >>> >>> >>> ------------------------------------------------------------------------------ >>> Check out the vibrant tech community on one of the world's most >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >>> >>> >>> >>> _______________________________________________ >>> Ryu-devel mailing list >>> Ryu-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/ryu-devel >>>
0001-Fix-simple_switch-for-multi-switch-env.patch
Description: 0001-Fix-simple_switch-for-multi-switch-env.patch
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Ryu-devel mailing list Ryu-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ryu-devel
