Hi,
Sorry about later reply.
Actually, Yes. It should be some OFPP_ANY.
But as I said, this is a bug from openflow-spec-v1.0.0 itself. In this official
spec, ofp_queue_stats_request was being defined as:
struct ofp_queue_stats_request {
uint16_t port_no;
uint8_t pad [2];
uint32_t queue_id;
/* All ports if OFPT_ALL. */
/* Align to 32-bits. */
/* All queues if OFPQ_ALL. */
};
And of course, RYU’s document also copy this line “All queues if OFPT_ALL”.
It’s a mistake actually, and it was being fixed since the v1.1.0. Hard to say.
But I think, since is a mistake, just let it be a mistake. So here I add a
declaration of OFPT_ALL. If someone use v1.0 and follow the official document,
it well be helpful.
On 24/11/2017, 14:25, "Iwase Yusuke" <[email protected]> wrote:
Hi,
Thank you for your posting your patch!
Refining example looks great for me! Thanks!
On 2017年11月20日 21:12, Meng Qingyu wrote:
> From: morland <[email protected]>
>
> Signed-off-by: morland <[email protected]>
> ---
> ryu/ofproto/ofproto_v1_0.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ryu/ofproto/ofproto_v1_0.py b/ryu/ofproto/ofproto_v1_0.py
> index 52d1b746..21671bc7 100644
> --- a/ryu/ofproto/ofproto_v1_0.py
> +++ b/ryu/ofproto/ofproto_v1_0.py
> @@ -51,6 +51,7 @@ OFPP_ALL = 0xfffc # All physical ports except
input port.
> OFPP_CONTROLLER = 0xfffd # Send to controller.
> OFPP_LOCAL = 0xfffe # Local openflow "port".
> OFPP_NONE = 0xffff # Not associated with a physical port.
> +OFPT_ALL = 0xffff # All physical ports. In fact this is a bug from
the spec of openflow1.0. Already been replaced to OFPP_ANY in openflow 1.1.0
Is this a typo of OFP"P"_ALL? But already "OFPP_ALL = 0xfffc".
(The "OFPT_" prefix means the OpenFlow Protocol message Type, right?)
I guess it is better to use "OFPP_ANY".
Thanks,
Iwase
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
