Hello list,
i don't think it's worth a new subminor and i don't see any other
problems with v14.6.2, so here is an "official" patch for the
problem that Gavin Troy has seen and reported over a week ago [1]
and for which i've already posted a(n equal) patch [2].
[1] <http://thread.gmane.org/gmane.mail.s-nail.user/65>
[2] <http://thread.gmane.org/gmane.mail.s-nail.user/67>
I don't think it's worth a subminor because even though i haven't
seen IMAP crashes in a while now, i do see connection breaks (due
to my weak network connection) and the total inability to handle
those correctly. Maybe i should also start and try to use the
IMAP cache.
Ciao everybody, and (try to) have a good time!
--steffen
s-nail-14_6_2-imap.patch, 2014-03-20:
Apply:
$ cd s-nail-14.6.2
$ patch -bu < s-nail-14_6_2-imap.patch
[$ make install]
Description:
Gavin Troy reported a segmentation violation that happens to
occur because the newly introduced `visible(message + j)' truly
accesses the message `j' which may excess the array bound. So
don't do that.
P.S.:
The fix is on [master] for more than a week, forgotten the patch.
Would need a holiday.
diff --git a/761dd87^:imap.c b/b0ce180:imap.c
index f925230..f6f8f5e 100644
--- a/imap.c
+++ b/imap.c
@@ -1844,8 +1844,9 @@ imap_getheaders(int volatile bot, int topp) /* TODO should take iterator!! */
for (i = bot; i <= topp; i += chunk) {
int j = i + chunk - 1;
+ j = MIN(j, topp);
if (visible(message + j))
- /*ok = */imap_fetchheaders(&mb, message, i, (j < topp ? j : topp));
+ /*ok = */imap_fetchheaders(&mb, message, i, j);
if (interrupts)
onintr(0); /* XXX imaplock? */
}
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
S-nail-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/s-nail-users
