Hi Nicola,

Nicola Cocchiaro <nicola.cocchi...@gmail.com> writes:
> The reason I originally asked was due to seeing some outbound connections 
> not completing but just hanging, until using umount.s3ql would let them 
> return with a TimeoutError (no less than 15 minutes later in all cases 
> seen). I was not able to dig much deeper at the time, but to experiment 
> more I put together a simple patch to add a configurable socket timeout to 
> all S3ql tools that may make use of it. I've attached it if you'd like to 
> consider it.

Thanks for the patch! I'm generally rather reluctant to add new
command-line options unless they are absolutely crucial. The problem is
that the number of possible configurations (and potential interaction
bug) goes up exponentially with every option.

In this case, I am not sure I fully understand in which situation this
option is intended to be used (so I'm pretty sure that a regular user
wouldn't know when to use it either, which is always a bad sign for a
command line argument). Could you give some additional details on that?

For example, if I'm not happy with the system timeout (which seems to be
15 minutes in your case), shouldn't this be adjusted on the os level as
well? And if not, is there really a need to make the timeout
configurable rather than having S3QL simply use an internal default?

Best,
-Nikolaus

-- 
Encrypted emails preferred.
PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C

             »Time flies like an arrow, fruit flies like a Banana.«

-- 
You received this message because you are subscribed to the Google Groups 
"s3ql" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to s3ql+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to