Matthieu, Thanks for taking care of the merge. Can you also delete the S4-7 branch (we created this earlier, before we started working on the S4-7-FIX branch).
Thanks Karthik On Mon, Mar 26, 2012 at 12:44 PM, Matthieu Morel (Resolved) (JIRA) < [email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/S4-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > Matthieu Morel resolved S4-7. > ----------------------------- > > Resolution: Fixed > > merged into piper branch commit f296947a8fa2ffc6a5e69047b626b4551a5f9d30 > > Thanks Karthik! > > > Netty to tolerate network glitches and connection loss > > ------------------------------------------------------ > > > > Key: S4-7 > > URL: https://issues.apache.org/jira/browse/S4-7 > > Project: Apache S4 > > Issue Type: Bug > > Reporter: Leo Neumeyer > > Assignee: Karthik Kambatla > > Fix For: 0.5 > > > > Attachments: S4-7-2.patch, S4-7.patch > > > > > > NettyEmitter connects to different partitions and creates channels over > which it communicates to other listeners. > > It suffers from the following issues -- > > 1. If the underlying topology changes, the channels and the associated > connections are not updated. > > 2. If a connection gets disconnected, it stays disconnected. > > 3. If for any reason, a connection can't be made, send() drops the > message to be sent. > > The solution is to - > > 1. Maintain a bounded messageQueue for each destination partition - if a > connection does not exist, the message should be queued. > > 2. Maintain a map of the channel used for each destination partition - > update this map on changes to topology, or on send() in case of > disconnections. > > 3. Every time a (re-)connection is made, send the queued messages first. > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators: > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > For more information on JIRA, see: http://www.atlassian.com/software/jira > > >
