[ https://issues.apache.org/jira/browse/S4-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592291#comment-13592291 ]
Daniel Gómez Ferro commented on S4-86: -------------------------------------- I found a couple of minor issues: * In S4Metrics line 86, we have to remove the extra call 'matcher.find()' * In ProcessingElement we are registering a per-PE timer (line 175) but we are not using it, since the calls are commented out (lines 441-470) > Metrics > ------- > > Key: S4-86 > URL: https://issues.apache.org/jira/browse/S4-86 > Project: Apache S4 > Issue Type: New Feature > Affects Versions: 0.6 > Reporter: Matthieu Morel > Fix For: 0.6 > > > Improving performance of S4 applications requires metrics that can be > analyzed. > Some metrics suggested in S4-65 are: > * event rate > * average/median event processing time > * event queue sizes > * number of PE instances > * number of processed events ( maybe within a sliding window) > * exceptions during event processing > We'd also add things like: > * shedding stats > * memory usage > * CPU load > * checkpointing: effective checkpoints, rejected ones > * etc... > Ideally, we'd be able to have different kinds of metrics, including > historical ones. > We also want to be able to expose those metrics through JMX, and probably > through other monitoring systems such as nagios. > A library that could be useful here is codahale's metrics > http://metrics.codahale.com/ , but there are alternatives that could be > evaluated as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira