[ 
https://issues.apache.org/jira/browse/S4-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599041#comment-13599041
 ] 

Matthieu Morel commented on S4-91:
----------------------------------

Thanks for the review and updates Daniel!

The abstraction for partition is also quite nice and could actually be passed 
to the sender directly. When working with the Helix integration with Kishore, 
we had come with a similar "Destination" abstraction.


Nevertheless, there are still some things to update:

* App.createZKNodeForPartition method will be called for each PE prototype on 
each node. I'm not sure this scales well, and it should be written only once.
* the isolation feature impacts the critical path for sending events even when 
not activated/available. E.g. in RemoteSender there is code that could be 
skipped if there is no isolation. (that quite easy to fix though)

It would be really nice to have this patch in the 0.6 release unfortunately I'm 
not sure how long fixing the above issues will take. Therefore I'll prepare a 
release of 0.6 first, then we should fix this patch, and possibly add it to a 
minor release, or to 0.7 (and that might help thinking with the Helix 
integration).



                
> Runtime isolation
> -----------------
>
>                 Key: S4-91
>                 URL: https://issues.apache.org/jira/browse/S4-91
>             Project: Apache S4
>          Issue Type: Task
>    Affects Versions: 0.6
>            Reporter: Aimee Cheng
>            Assignee: Aimee Cheng
>             Fix For: 0.7
>
>         Attachments: 
> 0001-add-exclusive-support-for-remote-stream-and-update-t.patch, 
> 0001-runtime-isolation-implement.patch
>
>
> We would like to use runtime isolation. PEs from the same APP can split to 
> several sub-sets and run in different JVM processes, so that we might get 
> some benefit from it, such as isolating the PEs which cost a lot of 
> resources, easier to find out the PE with problem. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to